Skip to content

Loosen restriction on optional arguments in CCPP.#917

Merged
jkbk2004 merged 22 commits into
NOAA-EMC:developfrom
dustinswales:feature/optional_args_again
Apr 25, 2025
Merged

Loosen restriction on optional arguments in CCPP.#917
jkbk2004 merged 22 commits into
NOAA-EMC:developfrom
dustinswales:feature/optional_args_again

Conversation

@dustinswales
Copy link
Copy Markdown
Collaborator

Description

When optional arguments were added back into the CCPP as part of #189, all variables that were conditionally allocated on the host side were required to be defined as optional within the schemes. This restriction required host-model logic to be implicitly built into the schemes and metadata. For example, scheme variables that were optional in the context of the host model, but always required within the context scheme, still needed to be defined as optional within the scheme. This resulted in schemes having an arbitrary/confusing mis-match of required/optional arguments.

This PR contains changes to the CCPP Framework (PR627) and CCPP Physics (PR248), reducing the restrictions on optional arguments and corresponding schemes changes, respectively. (There is also a small bugfix for the LW Jacobian used by RRTMGP).

Issue(s) addressed

N/A

Testing

RTs pass on Hera using Intel
(Running the full set now and will updated with links to RT logs when they complete)

Dependencies

N/A

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

@grantfirl
Copy link
Copy Markdown
Collaborator

grantfirl commented Mar 21, 2025

Note that the CCPP Framework PR changed to NCAR/ccpp-framework#638 and is already merged.

@grantfirl
Copy link
Copy Markdown
Collaborator

@dustinswales Added small metadata-only bugfix coming from another PR after it was already merged into ufs/dev and caught upon merge into NCAR/main: NCAR/ccpp-physics@0d4b4b9

@dustinswales dustinswales force-pushed the feature/optional_args_again branch from 52463c8 to 6ed022e Compare April 16, 2025 22:36
@jkbk2004 jkbk2004 merged commit de5d1c2 into NOAA-EMC:develop Apr 25, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants