Loosen restriction on optional arguments in CCPP.#917
Merged
jkbk2004 merged 22 commits intoApr 25, 2025
Conversation
…ture/optional_args_again
…ture/optional_args_again
…ture/optional_args_again
Merged
14 tasks
…ture/optional_args_again
…ture/optional_args_again
Collaborator
|
Note that the CCPP Framework PR changed to NCAR/ccpp-framework#638 and is already merged. |
Collaborator
|
@dustinswales Added small metadata-only bugfix coming from another PR after it was already merged into ufs/dev and caught upon merge into NCAR/main: NCAR/ccpp-physics@0d4b4b9 |
52463c8 to
6ed022e
Compare
…ture/optional_args_again
…ture/optional_args_again
jkbk2004
approved these changes
Apr 24, 2025
DusanJovic-NOAA
approved these changes
Apr 24, 2025
This was referenced May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When optional arguments were added back into the CCPP as part of #189, all variables that were conditionally allocated on the host side were required to be defined as
optionalwithin the schemes. This restriction required host-model logic to be implicitly built into the schemes and metadata. For example, scheme variables that wereoptionalin the context of the host model, but always required within the context scheme, still needed to be defined as optional within the scheme. This resulted in schemes having an arbitrary/confusing mis-match of required/optional arguments.This PR contains changes to the CCPP Framework (PR627) and CCPP Physics (PR248), reducing the restrictions on optional arguments and corresponding schemes changes, respectively. (There is also a small bugfix for the LW Jacobian used by RRTMGP).
Issue(s) addressed
N/A
Testing
RTs pass on Hera using Intel
(Running the full set now and will updated with links to RT logs when they complete)
Dependencies
N/A
Requirements before merging