Loosen restriction on optional arguments in CCPP Framework#2573
Conversation
|
@dustinswales Do you have any RT logs? I'm guessing this isn't supposed to change baselines? Let me know if you'd like me to run RTs on this. |
|
@grantfirl I'm addressing your issues in the physics and will rerun the RTs. |
I think that I fixed the inconsistency that I pointed out. I don't think anything else is required on the physics side. Just RTs at this point. You may want to double-check. |
|
Note that the ccpp-framework PR changed to NCAR/ccpp-framework#638 and is already merged. |
@grantfirl I just saw that. Thanks! |
@dustinswales Any update on these RTs? |
@grantfirl Some tests are failing and I need to look into this. Sigh. |
…r-model into feature/optional_args_again
…inswales/ufs-weather-model into feature/optional_args_again
|
@BrianCurtis-NOAA @FernandoAndrade-NOAA this pr is ready. |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
|
we can start merging process. |
|
@dustinswales fv3 new hash is NOAA-EMC/ufsatm@de5d1c2 |
…inswales/ufs-weather-model into feature/optional_args_again
|
Created an MOM6 code management issue: #2717 |
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
(Waiting on full set of RTs on Hera, Will update this PR when tests finished)
Input data Changes:
Library Changes/Upgrades:
Testing Log: