Skip to content

Loosen restriction on optional arguments in CCPP Framework#2573

Merged
jkbk2004 merged 42 commits into
ufs-community:developfrom
dustinswales:feature/optional_args_again
Apr 25, 2025
Merged

Loosen restriction on optional arguments in CCPP Framework#2573
jkbk2004 merged 42 commits into
ufs-community:developfrom
dustinswales:feature/optional_args_again

Conversation

@dustinswales
Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales commented Jan 27, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM - Loosen restriction on optional arguments in CCPP.

Priority:

  • Normal.

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.
    (Waiting on full set of RTs on Hera, Will update this PR when tests finished)

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Copy Markdown
Collaborator

grantfirl commented Mar 21, 2025

@dustinswales Do you have any RT logs? I'm guessing this isn't supposed to change baselines? Let me know if you'd like me to run RTs on this.

@dustinswales
Copy link
Copy Markdown
Collaborator Author

@grantfirl I'm addressing your issues in the physics and will rerun the RTs.
Thanks for syncing my branches!

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl I'm addressing your issues in the physics and will rerun the RTs. Thanks for syncing my branches!

I think that I fixed the inconsistency that I pointed out. I don't think anything else is required on the physics side. Just RTs at this point. You may want to double-check.

@grantfirl
Copy link
Copy Markdown
Collaborator

Note that the ccpp-framework PR changed to NCAR/ccpp-framework#638 and is already merged.

@dustinswales
Copy link
Copy Markdown
Collaborator Author

@grantfirl I'm addressing your issues in the physics and will rerun the RTs. Thanks for syncing my branches!

I think that I fixed the inconsistency that I pointed out. I don't think anything else is required on the physics side. Just RTs at this point. You may want to double-check.

@grantfirl I just saw that. Thanks!
I'll rerun the RTs now and update the logs.

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl I'm addressing your issues in the physics and will rerun the RTs. Thanks for syncing my branches!

I think that I fixed the inconsistency that I pointed out. I don't think anything else is required on the physics side. Just RTs at this point. You may want to double-check.

@grantfirl I just saw that. Thanks! I'll rerun the RTs now and update the logs.

@dustinswales Any update on these RTs?

@dustinswales
Copy link
Copy Markdown
Collaborator Author

@grantfirl I'm addressing your issues in the physics and will rerun the RTs. Thanks for syncing my branches!

I think that I fixed the inconsistency that I pointed out. I don't think anything else is required on the physics side. Just RTs at this point. You may want to double-check.

@grantfirl I just saw that. Thanks! I'll rerun the RTs now and update the logs.

@dustinswales Any update on these RTs?

@grantfirl Some tests are failing and I need to look into this. Sigh.

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing In Testing The PR that is currently in testing stages and removed Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Apr 24, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA @FernandoAndrade-NOAA this pr is ready.

@jkbk2004 jkbk2004 removed jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Apr 25, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

we can start merging process.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@dustinswales fv3 new hash is NOAA-EMC/ufsatm@de5d1c2

@jkbk2004
Copy link
Copy Markdown
Collaborator

Created an MOM6 code management issue: #2717

@jkbk2004 jkbk2004 merged commit 9e4778c into ufs-community:develop Apr 25, 2025
4 checks passed
@dustinswales dustinswales deleted the feature/optional_args_again branch April 25, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants