Skip to content

Revert ccpp prebuild call#189

Closed
climbfuji wants to merge 3 commits into
NOAA-EMC:developfrom
climbfuji:revert-ccpp-prebuild-call
Closed

Revert ccpp prebuild call#189
climbfuji wants to merge 3 commits into
NOAA-EMC:developfrom
climbfuji:revert-ccpp-prebuild-call

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Oct 23, 2020

Description

Revert a recent change that calls ccpp_prebuild.py from FV3 instead of ufs-weather-model to maintain consistency with existing documentation and tutorials for the remainder of the lifetime of ccpp_prebuild.py.

Issue(s) addressed

Addresses ufs-community/ufs-weather-model#135.

Testing

See ufs-community/ufs-weather-model#238.

Dependencies

NCAR/ccpp-physics#513
NOAA-EMC/NEMS#84
#189
ufs-community/ufs-weather-model#238

@climbfuji climbfuji force-pushed the revert-ccpp-prebuild-call branch 2 times, most recently from 9d266e0 to 3711b6f Compare October 27, 2020 01:30
@climbfuji climbfuji force-pushed the revert-ccpp-prebuild-call branch from 3711b6f to 187b43e Compare October 27, 2020 14:31
@climbfuji climbfuji added the wontfix This will not be worked on label Nov 24, 2020
@climbfuji
Copy link
Copy Markdown
Collaborator Author

Parts of this PR (pretty print, add --debug) are addressed in #202 - the reversal of the ccpp_prebuild.py calling directory will not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant