Land surface upgrades for HR2#663
Conversation
|
This needs reviews before the UFSWM PR can get into the commit queue. |
|
This branch (HelinWei-NOAA:hr2_land1) is 5 commits behind develop |
|
I will update to the current after I finish updating FV3 (Sam refactored FV3GFS_io.F90 last week). |
|
@DusanJovic-NOAA The code is now up-to-date with the develop. |
Move unused ccpp suites to suites_not_used directory (NOAA-EMC#665)
Revert "Move unused ccpp suites to suites_not_used directory (NOAA-EMC#665)"
jkbk2004
requested review from
DusanJovic-NOAA and
barlage
and removed request for
DusanJovic-NOAA and
barlage
barlage
left a comment
barlage
left a comment
There was a problem hiding this comment.
Looks good to me. I don't see any issues.
|
Requesting @BrianCurtis-NOAA @jkbk2004 @Qingfu-Liu @zach1221 for review and approvals. Apologies, I don't have permissions to add reviewers to this PR. |
|
@HelinWei-NOAA ufs-community/ccpp-physics#78 was merged. Please update the ccpp/physics submodule pointer and revert .gitmodules. |
|
@grantfirl Done.
|
|
Ok, this PR is ready to continue with merge process @jkbk2004 |
8 participants
Description
Land surface upgrades for HR2. The detail can be found from ccpp-physics PR #78
Is a change of answers expected from this PR? Yes
Issue(s) addressed
global workflow issue 1614
global workflow issue 1617
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs