land surface upgrades for HR2

[HelinWei-NOAA]

land surface upgrades for HR2:

• a new soil color dataset is introduced to Noah MP to reflect the right soil albedo to reduce the large warm bias found in the Sahel desert.
• restructure the approach to read in the Noah MP parameter table
• add an option for different diagnostic method to derive 2m t/q
• add GFS stability inside noahmp
• include wet leaf contribution factor
• z0m lai dependence

[grantfirl]

Looks good. Thanks for making the requested changes.

@dustinswales Please re-review since you requested changes and blocked merging.

[dustinswales]

Looks good.

[BrianCurtis-NOAA]

I know that there are approvals here, but since there have been code changes since the latest approval, can we get a re-approval from @dustinswales or @Qingfu-Liu of those changes?

[Qingfu-Liu]

@BrianCurtis-NOAA new changes look good, should rerun the regression tests

[dustinswales]

Looks good to me

[grantfirl]

@jkbk2004 It looks like this PR was not updated to the latest ufs/dev branch after the merge of #85. This shouldn't necessarily matter for testing because that PR only changed 2 files that are immaterial to the changes in this PR, but it is a mistake not to have updated this branch before final testing, IMO. I can still merge if we're all OK with it, I'm just pointing it out since I just got back from vacation.

[BrianCurtis-NOAA]

I would prefer that the code/hashes that go into the UFSWM repo be tested, so if there's a mistake in the upstream UFSWM testing branch it should be corrected and retested. Please do not merge.

[jkbk2004]

We can do a quick test to check the impact. BTW, we should hold this pr a bit.

[grantfirl]

@jkbk2004 @BrianCurtis-NOAA False alarm, I guess. I was looking through the commits and didn't see the merge commit for #85, but it looks like e9803fc did this. It should be OK to merge whenever you're ready.

[BrianCurtis-NOAA]

@jkbk2004 @BrianCurtis-NOAA False alarm, I guess. I was looking through the commits and didn't see the merge commit for #85, but it looks like e9803fc did this. It should be OK to merge whenever you're ready.

OK good. I was getting frustrated why I couldn't see the discrepancy you had mentioned and was about to ask if you were certain of it.

[FernandoAndrade-NOAA]

Ok, in that case it looks like this should be good to go. Testing for #1777 has finished successfully, please continue with the merge process.