Move unused ccpp suites to 'suites_not_used' directory#665
Merged
Conversation
39 tasks
Collaborator
|
@grantfirl can you review on this pr to move unused suites to separate directory? |
Collaborator
|
Moving old and unused suites to separate directory makes a sense. Please, go ahead to review review comments. |
grantfirl
approved these changes
Jun 27, 2023
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Seems fine to me. The reason to move them instead of remove them entirely is because someone might be using them for research, etc. that we're unaware of?
Collaborator
|
Testing on #1793 has completed, please go ahead and finalize reviews/approvals and begin the merging process for this PR @BrianCurtis-NOAA @junwang-noaa |
BrianCurtis-NOAA
approved these changes
Jun 28, 2023
jkbk2004
approved these changes
Jun 28, 2023
HelinWei-NOAA
added a commit
to HelinWei-NOAA/fv3atm
that referenced
this pull request
Jun 29, 2023
Move unused ccpp suites to suites_not_used directory (NOAA-EMC#665)
HelinWei-NOAA
added a commit
to HelinWei-NOAA/fv3atm
that referenced
this pull request
Jun 29, 2023
HelinWei-NOAA
added a commit
to HelinWei-NOAA/fv3atm
that referenced
this pull request
Jun 29, 2023
Revert "Move unused ccpp suites to suites_not_used directory (NOAA-EMC#665)"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves all unused ccpp suite definition files to a separate directory (suites_not_used)
Is a change of answers expected from this PR? No.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Regression test on Hera
What compilers / HPCs was it tested with? Intel and gnu
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? Yes
On what platform? Hera
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? No