Skip to content

inline post updates for P8 and ESMF -managed threading#569

Merged
BrianCurtis-NOAA merged 4 commits into
NOAA-EMC:developfrom
junwang-noaa:esmfthrds
Aug 9, 2022
Merged

inline post updates for P8 and ESMF -managed threading#569
BrianCurtis-NOAA merged 4 commits into
NOAA-EMC:developfrom
junwang-noaa:esmfthrds

Conversation

@junwang-noaa
Copy link
Copy Markdown
Collaborator

@junwang-noaa junwang-noaa commented Aug 2, 2022

Description

Changes in the this PR includes:

  1. With the ESMF -managed threading, the number of mpi tasks for UPP needs to be consistent with the traditional threading. To do that the write tasks per group used in UPP needs to set correctly considering the ESMF threading.
  2. Inline post interface update to resolve issues with missing post fields on pv and sigma levels when running in 32BIT=NO.
  3. Update upp to the latest develop branch to fix the pressure level TCDC fields when the cldfra/cld_amt is not in the history output.

Issue(s) addressed

Testing

How were these changes tested? Tested on hera
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

ufs-community/ufs-weather-model#1305

…ally considers ESMF-managed threading when active.
@junwang-noaa junwang-noaa changed the title Initialize wrttasks_per_group to allow inline post working with ESMF-managed threading inline post updates for P8 and ESMF -managed threading Aug 5, 2022
Copy link
Copy Markdown
Contributor

@WenMeng-NOAA WenMeng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UPP part looks good to me.

@WenMeng-NOAA
Copy link
Copy Markdown
Contributor

@DusanJovic-NOAA 's PR #570 has a decency on the UPP PR #538. If this PR is merged first, no upp revision update is needed in that PR.

Comment thread io/post_fv3.F90
Copy link
Copy Markdown
Member

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only really comment on the changes related to ESMF-managed threading in fv3_cap.F90. Looks all good to me.

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 8cbf892 into NOAA-EMC:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants