inline post updates for P8 and ESMF -managed threading#569
Merged
Conversation
…ally considers ESMF-managed threading when active.
15 tasks
WenMeng-NOAA
approved these changes
Aug 5, 2022
Contributor
WenMeng-NOAA
left a comment
There was a problem hiding this comment.
The UPP part looks good to me.
Contributor
|
@DusanJovic-NOAA 's PR #570 has a decency on the UPP PR #538. If this PR is merged first, no upp revision update is needed in that PR. |
SMoorthi-emc
approved these changes
Aug 5, 2022
DusanJovic-NOAA
approved these changes
Aug 5, 2022
theurich
approved these changes
Aug 5, 2022
Member
theurich
left a comment
There was a problem hiding this comment.
I can only really comment on the changes related to ESMF-managed threading in fv3_cap.F90. Looks all good to me.
BrianCurtis-NOAA
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes in the this PR includes:
Issue(s) addressed
Testing
How were these changes tested? Tested on hera
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
ufs-community/ufs-weather-model#1305