Update inline post for multiple domains#570
Merged
Merged
Conversation
Fix compilation without inline post.
16 tasks
junwang-noaa
reviewed
Sep 1, 2022
Collaborator
|
RT test runs all passed for the upstream PR 1362. Can we have final approvals and start merging this pr? |
Contributor
|
Why not set default to YES for inline post?
I hope most people want to use inline post.
Moorthi
…On Thu, Sep 1, 2022 at 9:54 AM Jun Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CMakeLists.txt
<#570 (comment)>:
> @@ -25,10 +25,8 @@ add_subdirectory(atmos_cubed_sphere)
if(INLINE_POST)
set(BUILD_POSTEXEC OFF)
add_subdirectory(upp)
- set(POST_SRC io/inline_post.F90 io/post_nems_routines.F90 io/post_fv3.F90)
-else()
Does this mean inline_post will be always on?
—
Reply to this email directly, view it on GitHub
<#570 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYTLCYRE6QD45ZCEQV3V4CYPNANCNFSM55K355KA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Collaborator
Author
I agree, it should be ON by default. I think initially, when inline post was added, it was running only on few platforms, so the default was made to be OFF, and it was turned ON on those platforms that supported it. At this moment I believe inline post runs on most platforms. |
junwang-noaa
approved these changes
Sep 1, 2022
WenMeng-NOAA
approved these changes
Sep 1, 2022
Collaborator
|
@BrianCurtis-NOAA @DeniseWorthen we need one more approval from cm group. |
BrianCurtis-NOAA
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a detailed description of what this PR does.
This PR updates inline post to support multiple domains (nests).
What bug does it fix, or what feature does it add? Multiple domains in inline post
Is a change of answers expected from this PR? Yes.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Regression test on Hera
What compilers / HPCs was it tested with? Hera/Intel
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes. Hera.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? Yes.
If so add the "waiting for other repos" label and list the upstream PRs