thompson_fluxcalc fix#538
Closed
bbakernoaa wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@bbakernoaa The changes are in Chunxi's FV3ATM PR #525, right? Thanks |
Contributor
Author
|
@junwang-noaa Yes thats correct. |
Collaborator
|
We will commit PR#525. You can close this PR. Thanks |
Contributor
Author
|
@junwang-noaa Thanks. PR#525 still needs to pass the ORT correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching to to Thompson in P8b with the coupled aerosols the values were not calculated by default and therefore zeros were passed to the GOCART model through the NUOPC layer causing no large scale wet deposition. This PR adds back in the capability that was added to the GFDL MP for the coupled GOCART model for the calculation of the large scale wet deposition. Here we use the instantaneous tendency to calculate the flux. This has no impact on the meteorology and only adds in the needed variables for the GOCART model.
See NCAR/ccpp-physics#926 for more details