fixes for regional decomposition test#549
Closed
junwang-noaa wants to merge 3 commits into
Closed
Conversation
17 tasks
Contributor
|
This has been merged into #553 |
Collaborator
Author
|
Merged through #553. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some fixes are made to dycore to resolve the issue with the regional decomposition reproducibility.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
on hera
What compilers / HPCs was it tested with?
Intel.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. Different decompositions have been tested with regional_3km test.
Have the ufs-weather-model regression test been run? On what platform?
Yes.
The regional test baseline will change due to the fix.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)