[dev/gfs.v17] Write UFSWM logs to output directories and add UPP foundation T land mask#4946
Merged
DavidHuber-NOAA merged 3 commits intoJun 2, 2026
Conversation
Contributor
|
@dpsarmie when you are ready, please mark this PR as ready for review. All tests passed on WCOSS2: |
16 tasks
DavidHuber-NOAA
approved these changes
Jun 1, 2026
JessicaMeixner-NOAA
approved these changes
Jun 1, 2026
Contributor
Contributor
Author
Contributor
|
Thanks @dpsarmie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will update the UFSWM hash which will bring in the ability to write UFSWM subcomponent logs to their respective output directories.
There was a request from NCO and GW to have the logs of MOM6, CMEPS, and CICE be written to their output directories instead of the common run directory. There was also a bug in the labeling of the CICE logs when in IAU mode for the 00Z cycles.
The updated UFSWM now uses the same logging function across all subcomponents (CICE was previously using an independent logging function, which was the source of the filename bug). The logging function now accepts an output directory argument and it has been set to the subcomponent output directories.
log.ice.fHHHHwill now be written to./CICE_OUTPUTlog.cmeps.fHHHHwill now be written to./CMEPS_RESTART(CMEPS does not currently have an output directory)YYYYMMDD.HHHHMM.mom6.resand .f06 will now be written to./MOM6_OUTPUTThis is for the GFSv17 production branch. I'm working on a more flexible and configuration defined/controlled option for develop
PR #4936 :: Update UFSWM hash with UPP foundation temp mask
The update to the head of
production/GFS.v17will also bring in changes from #4936. This includes an update to UPP that adds a land mask to the ocean foundation temperature field. This only affects one field in the grib files that are created by UPP. No science changes occurred with this update.The UPP PR can be found here: NOAA-EMC/UPP#1530
Type of change
Change characteristics
How has this been tested?
The UFSWM has been tested using the set of GFSv17 baselines and the regression test system in UFSWM.
A
C96C48mx500_S2SW_cyc_gfscase will still need to be run as a test to ensure that the new logging functionality satisfies the NCO request.Checklist