Skip to content

[dev/gfs.v17] Write UFSWM logs to output directories and add UPP foundation T land mask#4946

Merged
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:dev/gfs.v17from
dpsarmie:v17/logs_to_ouptut_dir
Jun 2, 2026
Merged

[dev/gfs.v17] Write UFSWM logs to output directories and add UPP foundation T land mask#4946
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:dev/gfs.v17from
dpsarmie:v17/logs_to_ouptut_dir

Conversation

@dpsarmie
Copy link
Copy Markdown
Contributor

@dpsarmie dpsarmie commented May 28, 2026

Description

This PR will update the UFSWM hash which will bring in the ability to write UFSWM subcomponent logs to their respective output directories.

There was a request from NCO and GW to have the logs of MOM6, CMEPS, and CICE be written to their output directories instead of the common run directory. There was also a bug in the labeling of the CICE logs when in IAU mode for the 00Z cycles.

The updated UFSWM now uses the same logging function across all subcomponents (CICE was previously using an independent logging function, which was the source of the filename bug). The logging function now accepts an output directory argument and it has been set to the subcomponent output directories.

log.ice.fHHHH will now be written to ./CICE_OUTPUT
log.cmeps.fHHHH will now be written to ./CMEPS_RESTART (CMEPS does not currently have an output directory)
YYYYMMDD.HHHHMM.mom6.res and .f06 will now be written to ./MOM6_OUTPUT

This is for the GFSv17 production branch. I'm working on a more flexible and configuration defined/controlled option for develop

PR #4936 :: Update UFSWM hash with UPP foundation temp mask

The update to the head of production/GFS.v17 will also bring in changes from #4936. This includes an update to UPP that adds a land mask to the ocean foundation temperature field. This only affects one field in the grib files that are created by UPP. No science changes occurred with this update.
The UPP PR can be found here: NOAA-EMC/UPP#1530

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

The UFSWM has been tested using the set of GFSv17 baselines and the regression test system in UFSWM.
A C96C48mx500_S2SW_cyc_gfs case will still need to be run as a test to ensure that the new logging functionality satisfies the NCO request.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@dpsarmie when you are ready, please mark this PR as ready for review.

All tests passed on WCOSS2:

Mon Jun  1 12:20:29 UTC 2026
******** C48_ATM_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 29 2026 19:20:23    May 29 2026 20:15:16

******** C48mx500_3DVarAOWCDA_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 29 2026 19:20:25    May 29 2026 19:35:34
202103250000        Done    May 29 2026 19:20:25    May 29 2026 21:00:20

******** C48mx500_hybAOWCDA_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 29 2026 19:20:22    May 29 2026 19:35:34
202103250000        Done    May 29 2026 19:20:22    May 29 2026 20:40:19

******** C48_S2SW_extended_cice_fix ********
202103231200       Done    May 29 2026 19:20:23    May 30 2026 00:55:16

******** C96_atm3DVar_extended_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 29 2026 19:20:23    May 29 2026 19:40:17
202112210000        Done    May 29 2026 19:20:23    May 30 2026 00:00:40
202112210600        Done    May 29 2026 19:20:23    May 30 2026 00:55:16
202112211200        Done    May 29 2026 19:45:20    May 30 2026 02:20:28
202112211800        Done    May 30 2026 00:05:15    May 30 2026 04:50:29

******** C96C48_hybatmDA_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 29 2026 19:20:26    May 29 2026 19:40:41
202112210000        Done    May 29 2026 19:20:26    May 29 2026 21:35:16
202112210600        Done    May 29 2026 19:20:26    May 29 2026 21:25:34

******** C96C48_hybatmsnowDA_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 29 2026 19:20:22    May 29 2026 19:40:19
202112201800        Done    May 29 2026 19:20:22    May 29 2026 21:30:19
202112210000        Done    May 29 2026 19:20:22    May 29 2026 21:25:35

******** C96C48_hybatmsoilDA_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    May 29 2026 19:20:17    May 29 2026 19:40:20
202205151200        Done    May 29 2026 19:20:17    May 29 2026 21:35:25
202205151800        Done    May 29 2026 19:20:17    May 29 2026 21:30:23

******** C96C48mx500_S2SW_cyc_gfs_cice_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 29 2026 19:15:30    May 29 2026 19:35:34
202112201800        Done    May 29 2026 19:15:30    May 29 2026 22:00:26
202112210000        Done    May 29 2026 19:15:30    May 29 2026 22:20:24
202112211800        Done    May 29 2026 19:40:40    May 29 2026 22:30:22

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully label Jun 1, 2026
@dpsarmie dpsarmie marked this pull request as ready for review June 1, 2026 14:53
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

@dpsarmie - Can you please update this PR with the descriptions from #4936 -- particularly the change to the UPP needs to be documented here.

@dpsarmie dpsarmie changed the title [dev/gfs.v17] Allow UFSWM to write logs to output directories [dev/gfs.v17] Write UFSWM logs to output directories and add UPP foundation T land mask Jun 2, 2026
@dpsarmie
Copy link
Copy Markdown
Contributor Author

dpsarmie commented Jun 2, 2026

@dpsarmie - Can you please update this PR with the descriptions from #4936 -- particularly the change to the UPP needs to be documented here.

Ok, description and title were modified to reflect the UPP changes.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

Thanks @dpsarmie

@DavidHuber-NOAA DavidHuber-NOAA merged commit d256c1f into NOAA-EMC:dev/gfs.v17 Jun 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants