[production/GFSv17] Add output argument to log_restart_fh function

[dpsarmie]

Commit Queue Requirements:

• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

NCO has asked that the log files for each subcomponent be placed inside of their respective OUTPUT folders. To accomplish this, an argument was added to the log_restart_fh function. The subcomponents will add their respective OUTPUT directory (or RESTART in the case of CMEPS) to the function.

This will also be added to develop but the feature will be controlled via a user config option. For the production branch, the output directories will just act as the default.

Commit Message:

* UFSWM - Add output argument to log_restart_fh
  * CICE - Add log_restart_fh capability and remove ufs_logfhour
  * CMEPS - Add output_dir argument to log_restart_fh
  * MOM6 - Add output_dir argument to log_restart_fh

Priority:

• Normal

Git Tracking

UFSWM:

No issue for this commit

Sub component Pull Requests:

• CICE - [production/GFS.v17] Remove ufs_logfhour call and add log_restart_fh NOAA-EMC/CICE#112
• CMEPS - [production/GFS.v17] Add output_dir argument to log_restart_fh function NOAA-EMC/CMEPS#169
• MOM6 - [production/GFSv17] Add output directory argument for logs NOAA-EMC/MOM6#177

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update NOT required.

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

Testing Remarks:

[dpsarmie]

This was tested against the GFSv17 regression test baselines and no baseline changes were confirmed.

This was tested by @DavidHuber-NOAA in the global workflow and the logs files were in the correct locations with the correct filenames.

This should be ready to merge into the v17 production branch.

[dpsarmie]

And all subcomponent PRs were reviewed, tested, and merged into their respective production branches.

[NickSzapiro-NOAA]

In .gitmodules, CICE is pointing to develop branch @dpsarmie

[dpsarmie]

In .gitmodules, CICE is pointing to develop branch @dpsarmie

Thank you for catching that. Updated .gitmodules and confirmed that the hashes that were there are representative of the production branches in the subcomponents.

[NickSzapiro-NOAA]

Thanks for getting it to work