Skip to content

update GSI hash to pull in changes to GSI-fix, which in turn pulls in updates to build_gsinfo#4350

Closed
jswhit wants to merge 2 commits into
NOAA-EMC:developfrom
jswhit2:update_GSI-build_gsinfo
Closed

update GSI hash to pull in changes to GSI-fix, which in turn pulls in updates to build_gsinfo#4350
jswhit wants to merge 2 commits into
NOAA-EMC:developfrom
jswhit2:update_GSI-build_gsinfo

Conversation

@jswhit
Copy link
Copy Markdown
Contributor

@jswhit jswhit commented Dec 17, 2025

Description

build_gsinfo-fix was updated to change QC for 2m obs (NOAA-PSL/build_gsinfo-fix#15 and NOAA-PSL/build_gsinfo-fix#16)

GSI-fix was then updated to point to a new build_gsinfo-fix hash (NOAA-EMC/GSI-fix#57)

GSI was then updated to point to the new GSI-fix hash (NOAA-EMC/GSI#973).

This PR updates the GSI hash to get the changes to GSI/GSI-fix/build_gsinfo-fix which are needed for the GFSv17 parallels.

-->

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • GFS

  • Is this a breaking change (a change in existing functionality)? NO

  • Does this change require a documentation update? NO

  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.). NO

How has this been tested?

not yet tested

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Thank you @jswhit for opening this PR and issue #4351.

g-w PR #4349 has the same change. I'm fine with either PR moving forward. Both update the GSI hash to gsi_enkf.fd @ dcf055d

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

This PR may be closed. It contains the same change as #4349. PR #4349 was merged into develop at 5a19098

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Merge develop at 5a19098 into jswhit2:update_GSI-build_gsinfo. This PR now has Files changed 0

Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants