Skip to content

update sorc/gsi_enkf.fd to bring in updated build_gsinfo-fix#4349

Merged
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dsfcalc
Dec 18, 2025
Merged

update sorc/gsi_enkf.fd to bring in updated build_gsinfo-fix#4349
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dsfcalc

Conversation

@RussTreadon-NOAA

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates the sorc/gsi_enkf.fd hash to bring in fix/build_gsinfo-fix updates.

Resolves #4340
Resolves #4341

Type of change

  • Bug fix - uses correct values / settings in GSI fix/build_gsinfo-fix

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES - changes in fix/build_gsinfo-fix alter GFS analysis results
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Run C96C48mx500_S2SW_cyc_gfs on Hera using this PR for HOMEgfs

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Updating to gsi_enkf.fd @ dcf055d brings in the following changes in addition to updating the fix submodule hash:

  • modulefiles/gsi_container.intel.lua - change for machine=container
  • regression/regression_param.sh - change for machine=noaacloud
  • src/gsi/read_pblh.f90 - replace ufbin3 with ufbevn, required when moving to bufr/12.3
  • ush/detect_machine.sh - change for machine=container

None of these changes alter GSI results.

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

@CatherineThomas-NOAA , @JessicaMeixner-NOAA , @RuiyuSun, @ClaraDraper-NOAA : here is a draft PR to pull the updated GSI hash into g-w develop. I have not run an tests to confirm acceptable behavior.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Dec 17, 2025
ClaraDraper-NOAA
ClaraDraper-NOAA approved these changes Dec 17, 2025
View reviewed changes

@ClaraDraper-NOAA ClaraDraper-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming none of the other commits to gsi_enkf.fd are problematic, looks good to me.

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Do any of our existing g-w CI cases exercise all GFS v17 functionality? If yes, which case? I can run this case. We can check the output to confirm that updated fix/build_gsinfo-fix works as intended.

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Dec 17, 2025
Closed
14 tasks
@CatherineThomas-NOAA

CatherineThomas-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA

Do any of our existing g-w CI cases exercise all GFS v17 functionality? If yes, which case?

Yes, the CI case dev/ci/cases/pr/C96C48mx500_S2SW_cyc_gfs.yaml is our v17 low res case. Thanks for offering to run it.

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

@RussTreadon-NOAA

Do any of our existing g-w CI cases exercise all GFS v17 functionality? If yes, which case?

Yes, the CI case dev/ci/cases/pr/C96C48mx500_S2SW_cyc_gfs.yaml is our v17 low res case. Thanks for offering to run it.

Great!. I'll install this PR on Hera and use it to run C96C48mx500_S2SW_cyc_gfs

@CatherineThomas-NOAA

CatherineThomas-NOAA commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

I've cloned the PR branch and see these differences with current develop:

  • obs_input_reanl_ncep_ozone.txt has updates for dsfcalc and dthin for multiple sensors, plus seviri m11
  • updated gross/ermax in convinfo for 2m obs
  • container/cloud-related changes
  • ufbin3

These changes are all expected. Things look to be in order to me. I'll wait to see the CI test output before approving.

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Launch g-w CI on Hera from RussTreadon-NOAA:bugfix/dsfcalc at 4c09490

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Hera g-w CI

Install RussTreadon-NOAA:bugfix/dsfcalc at 4c09490 on Hera. Run g-w CI with the following results

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_ATM_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202103231200        Done    Dec 18 2025 13:53:46    Dec 18 2025 14:55:10

SKIP C48_ATM_ecflow on hera

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_S2SW_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202103231200        Done    Dec 18 2025 13:53:47    Dec 18 2025 15:00:21

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_S2SWA_gefs_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202103231200        Done    Dec 18 2025 13:53:48    Dec 18 2025 15:30:15

SKIP C48_S2SWA_gefs_RT on hera

SKIP C48_S2SW_extended on hera

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48mx500_3DVarAOWCDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202103241800        Done    Dec 18 2025 13:53:50    Dec 18 2025 14:20:18
202103250000        Done    Dec 18 2025 13:53:50    Dec 18 2025 15:55:16

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48mx500_hybAOWCDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202103241800        Done    Dec 18 2025 13:53:51    Dec 18 2025 14:20:20
202103250000        Done    Dec 18 2025 13:53:51    Dec 18 2025 15:35:15

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201800        Done    Dec 18 2025 13:53:52    Dec 18 2025 14:20:22
202112210000        Done    Dec 18 2025 13:53:52    Dec 18 2025 16:35:19
202112210600        Done    Dec 18 2025 13:53:52    Dec 18 2025 16:25:17

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmsnowDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201200        Done    Dec 18 2025 13:53:53    Dec 18 2025 14:20:23
202112201800        Done    Dec 18 2025 13:53:53    Dec 18 2025 16:40:21
202112210000        Done    Dec 18 2025 13:53:53    Dec 18 2025 16:25:19

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmsoilDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202205150600        Done    Dec 18 2025 13:53:55    Dec 18 2025 14:20:25
202205151200        Done    Dec 18 2025 13:53:55    Dec 18 2025 16:40:22
202205151800        Done    Dec 18 2025 13:53:55    Dec 18 2025 16:45:26

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_ufs_hybatmDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202402231800        Done    Dec 18 2025 13:53:56    Dec 18 2025 14:20:27
202402240000        Done    Dec 18 2025 13:53:56    Dec 18 2025 16:57:24
202402240600        Done    Dec 18 2025 13:53:56    Dec 18 2025 16:50:22

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_ufsgsi_hybatmDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202402231800        Done    Dec 18 2025 13:53:57    Dec 18 2025 14:20:28
202402240000        Done    Dec 18 2025 13:53:57    Dec 18 2025 17:00:32
202402240600        Done    Dec 18 2025 13:53:57    Dec 18 2025 16:50:24

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48mx500_S2SW_cyc_gfs_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201200        Done    Dec 18 2025 13:53:59    Dec 18 2025 14:25:26
202112201800        Done    Dec 18 2025 13:53:59    Dec 18 2025 17:15:30
202112210000        Done    Dec 18 2025 13:53:59    Dec 18 2025 17:35:27
202112211800        Done    Dec 18 2025 14:30:34    Dec 18 2025 17:50:29

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_atm3DVar_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201800        Done    Dec 18 2025 13:54:00    Dec 18 2025 14:25:27
202112210000        Done    Dec 18 2025 13:54:00    Dec 18 2025 16:55:28
202112210600        Done    Dec 18 2025 13:54:00    Dec 18 2025 16:50:27

SKIP C96_atm3DVar_extended on hera

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_gcafs_cycled_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201200        Done    Dec 18 2025 13:54:01    Dec 18 2025 14:20:35
202112201800         gcafs_arch_tars                    20094403                DEAD                  15         2          20.0
202112210000        Done    Dec 18 2025 13:54:01    Dec 18 2025 16:20:31

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_gcafs_cycled_noDA_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202112201200        Done    Dec 18 2025 13:54:02    Dec 18 2025 14:20:33
202112201800         gcafs_arch_tars                    20093118                DEAD                  15         2          22.0
202112210000        Done    Dec 18 2025 13:54:02    Dec 18 2025 15:20:39

/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96mx100_S2S_pr4349
   CYCLE         STATE           ACTIVATED              DEACTIVATED
199405010000        Done    Dec 18 2025 13:54:04    Dec 18 2025 15:25:30

gcafs_arch_tars failed in both cases for the same reason.

FileNotFoundError: FATAL ERROR: Required file, directory, or glob gcafs.20211220/18/products/atmos/grib2/0p25/gcafs.t18z.pres_b.0p25.f000.grib2 not found!

This is an expected error. See g-w issue #4334 for details.

Of note for this PR case C96C48mx500_S2SW_cyc_gfs successfully ran to completion.

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

C96C48mx500_S2SW_cyc_gfs results

Compare C96C48mx500_S2SW_cyc_gfs results from this PR with those from develop. Examined first analysis cycle, 20211220 18Z. The following differences with respect to develop were found

  1. dsfcalc=1 for amsua, mhs, and iasi
  2. metop-c amsua, mhs, and iasi only processed once
  3. different assimilated data counts and statistics for T and q types 181 and 187
  4. different assimilated data counts and statistics for brightness temperatures metop-b and metop-c amsua, mhs, and iasi
  5. different assimilated data counts and statistics for brightness temperatures metop-b, n18, n19 avhrr
  6. assimilate seviri_m11
  7. monitor viirs-m_npp, viirs-m_j1, viirs-m_j2

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

g-w CI has been successfully run on Hera. This PR is ready for review.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review December 18, 2025 19:16
@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

@CatherineThomas-NOAA and @JessicaMeixner-NOAA : The PR is ready for review. This PR updates sorc/gsi_enkf.fd to bring in the revised build-gsinfo-fix.

CatherineThomas-NOAA
CatherineThomas-NOAA approved these changes Dec 18, 2025
View reviewed changes

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test looks good to me @RussTreadon-NOAA. I'll add on that I also see identical files where I expect: the first cycle forecasts were identical, as well as the analyses for the ocean, ice, and snow in the first cycle. Thanks for all of your work on this!

@RussTreadon-NOAA

RussTreadon-NOAA commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @CatherineThomas-NOAA for checking output. Good to hear that results look OK.

@aerorahul and @DavidHuber-NOAA : This PR is ready for final review and additional g-w CI, if needed.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Passed (cm) Manual CI passed on Hera label Dec 18, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit 5a19098 into NOAA-EMC:develop Dec 18, 2025
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/dsfcalc branch December 21, 2025 20:28
RussTreadon-NOAA added a commit to bhuang95/global-workflow that referenced this pull request Feb 6, 2026
@RussTreadon-NOAA
replace atmf009 depdendency with atm.f009 (NOAA-EMC#4349)
cfe8df4
This was referenced Feb 12, 2026
Closed
Closed
This was referenced Feb 17, 2026
Closed
Closed
Merged
Merged
DavidHuber-NOAA pushed a commit that referenced this pull request Feb 25, 2026
@CatherineThomas-NOAA
Update GSI hash for 2m T and q ob gross check (#4581)
0087adf 
This updates the GSI hash in order to make the 2m T and q ob gross
checks consistent for all dates in the build_gsinfo-fix submodule. The
original PRs to adjust the gross checks were
#4349 and
#4357.

There is an additional commit as part of the GSI hash update
(NOAA-EMC/GSI#978). It only impacts diagnostic
output and does not change answers when cycling.

Resolves #4544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClaraDraper-NOAA ClaraDraper-NOAA ClaraDraper-NOAA approved these changes

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels

CI-Hera-Passed (cm) Manual CI passed on Hera

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create_gsi_info incorrect gross error checks for T2m & q2m amsua, mhs, iasi metop-c in gfs v17 gsi obs_input list twice

4 participants

@RussTreadon-NOAA @CatherineThomas-NOAA @ClaraDraper-NOAA @DavidHuber-NOAA