Skip to content

Parallelize surface increment regridding#4194

Merged
DavidHuber-NOAA merged 37 commits into
NOAA-EMC:developfrom
DavidNew-NOAA:feature/multi_regrid
Nov 7, 2025
Merged

Parallelize surface increment regridding#4194
DavidHuber-NOAA merged 37 commits into
NOAA-EMC:developfrom
DavidNew-NOAA:feature/multi_regrid

Conversation

@DavidNew-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR parallelizes the deterministic and ensemble surface increment regridding. The file IO (staging and saving to COM) is parallelized with MPMD/CFP and the regridding itself is parallelized internally to the application the regrids in ufs_utils.

Resolves #4135

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

Clone, build, and run full CI suite on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Comment thread dev/parm/config/gfs/config.resources Fixed
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Comment thread env/WCOSS2.env Outdated
Comment thread dev/parm/config/gfs/config.resources Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
aerorahul
aerorahul previously approved these changes Nov 6, 2025
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Outdated
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Comment thread ush/regrid_gsiSfcIncr_to_tile.sh Fixed
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

Launching CI on C6.

@emcbot emcbot added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Nov 6, 2025
@DavidNew-NOAA
Copy link
Copy Markdown
Contributor Author

@DavidHuber-NOAA Thanks! I was going to re-run CI manually on Hera but I see you've triggered automated CI. Crossing my fingers I didn't break anything

@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Nov 6, 2025
@emcbot emcbot added CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Running labels Nov 6, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit 61222b7 into NOAA-EMC:develop Nov 7, 2025
5 checks passed
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

All tests passed on C6. Merging.

@DavidNew-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @DavidHuber-NOAA and @aerorahul !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallelize the ensemble surface analysis job

8 participants