Skip to content

Bugfixes from IMS C++ code additions#4105

Merged
DavidHuber-NOAA merged 6 commits into
NOAA-EMC:developfrom
CoryMartin-NOAA:feature/ims-fix
Sep 29, 2025
Merged

Bugfixes from IMS C++ code additions#4105
DavidHuber-NOAA merged 6 commits into
NOAA-EMC:developfrom
CoryMartin-NOAA:feature/ims-fix

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Sep 26, 2025 •
edited by aerorahul
Loading

Description

PR #4000 switched to using the C++ IMS code and in that we changed how that part of the snow analysis job is called, in this, I introduced a bug that would arise if the IMS input file was missing. This fixes this.

Resolves #3980

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

@JessicaMeixner-NOAA has tested as part of GFSv17 real time attempts

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Sep 26, 2025
jiaruidong2017
jiaruidong2017 previously approved these changes Sep 26, 2025
View reviewed changes
JessicaMeixner-NOAA
JessicaMeixner-NOAA previously approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the script changes are the same as what we are using in the rt15 tests that succeeded. Thank you!

CatherineThomas-NOAA
CatherineThomas-NOAA previously approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Did not test myself but was tested in @JessicaMeixner-NOAA's run of rt15. Approve. Thanks @CoryMartin-NOAA!

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Sep 26, 2025

@CoryMartin-NOAA Can you merge in develop and resolve the GDASApp hash conflict?

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Sep 26, 2025

@DavidHuber-NOAA done, thanks

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean solution!

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Sep 26, 2025

@CoryMartin-NOAA or @JessicaMeixner-NOAA would you mind running C96C48_hybatmsnowDA and C96C48mx500_S2SW_gfs_cyc test cases on WCOSS2? I don't think we need to run the full suite.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Sep 26, 2025

@DavidHuber-NOAA sure, let me start cloning a fresh copy now

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Sep 26, 2025

Both have been started on Cactus, see: /lfs/h2/emc/ptmp/cory.r.martin/g-w/PR4105/RUNTESTS I'll check status Monday AM

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Sep 29, 2025

All tasks succeeded on both tests on Cactus

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully label Sep 29, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit 5706400 into NOAA-EMC:develop Sep 29, 2025
5 checks passed
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Sep 29, 2025
Merged
12 tasks
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Oct 8, 2025
@weihuang-jedi
Merge branch 'develop' of github.com:NOAA-EPIC/global-workflow-cloud …
2f70d7c 
…into feature/adjust_tasks_per_node_layout

* 'develop' of github.com:NOAA-EPIC/global-workflow-cloud:
  Adding workflow infrastructure for wave_stat and wave_stat_pnt jobs (NOAA-EMC#3846)
  Add ush and parm of SPOC (NOAA-EMC#3944)
  Bugfixes from IMS C++ code additions (NOAA-EMC#4105)
  Increase C96 gcdas fcst wall time to 1.5 hours (NOAA-EMC#4108)
  Use default stochastic physics (NOAA-EMC#4073)
  Fix new feature template (NOAA-EMC#4104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA left review comments

@jiaruidong2017 jiaruidong2017 jiaruidong2017 left review comments

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA left review comments

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify snow analysis jobs to use new C++ IMS SCF preprocessor

5 participants

@CoryMartin-NOAA @DavidHuber-NOAA @JessicaMeixner-NOAA @jiaruidong2017 @CatherineThomas-NOAA