Skip to content

Add ush and parm of SPOC#3944

Merged
DavidHuber-NOAA merged 11 commits into
NOAA-EMC:developfrom
xincjin-NOAA:develop
Sep 29, 2025
Merged

Add ush and parm of SPOC#3944
DavidHuber-NOAA merged 11 commits into
NOAA-EMC:developfrom
xincjin-NOAA:develop

Conversation

@xincjin-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA xincjin-NOAA commented Aug 14, 2025

Description

This PR resolves issue #3943

This PR adds the capability to process python scripts and yaml files from SPOC (https://github.com/NOAA-EMC/spoc) so that GDASApp can use them to convert observation files into IODA formal.

The dependent GDASApp PR has been merged.
Resolves #3943

Type of change

  • Bug fix (fixes something broken)
  • [ x] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Comment thread sorc/link_workflow.sh Fixed
Comment thread sorc/link_workflow.sh Fixed
@CoryMartin-NOAA CoryMartin-NOAA added the JEDI Feature development to support JEDI-based DA label Aug 14, 2025
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xincjin-NOAA I think we need to include a GDASApp hash change in here

@xincjin-NOAA
Copy link
Copy Markdown
Contributor Author

@CoryMartin-NOAA added here and above:
GDASApp: #261cd47

@xincjin-NOAA
Copy link
Copy Markdown
Contributor Author

@CoryMartin-NOAA Updated the hash for the gdas.cd submodule.

Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since it updates GDAS hash, we probably need to wait for other PRs to go in first, like #3798

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA Now that #3798 has been merged, we can begin testing this PR once the conflicting GDASApp hash is resolved. Would you be able to do that?

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA Xin is on leave for a few weeks, so this PR can move back in the queue unless you'd prefer that we fork from his fork and work to get this in.

DavidNew-NOAA
DavidNew-NOAA previously approved these changes Aug 22, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

That's fine. We can wait for Xin to come back. I'll add the needs submodule update label. @xincjin-NOAA when you are able to update the hash, please remove this label.

@DavidHuber-NOAA DavidHuber-NOAA added the needs submodule update Requires submodule PRs to be merged label Aug 22, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA , is it possible to update the hash for sorc/gdas.cd in xincjin-NOAA:develop to 3809a5d or later.

@xincjin-NOAA
Copy link
Copy Markdown
Contributor Author

@RussTreadon-NOAA updated the hash for sorc/gdas.cd. Thanks.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Perfect! Thank you very much, @xincjin-NOAA .

@DavidHuber-NOAA DavidHuber-NOAA removed the needs submodule update Requires submodule PRs to be merged label Sep 25, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA Could you please merge develop into this branch and resolve the conflict on the GDASApp hash?

DavidNew-NOAA
DavidNew-NOAA previously approved these changes Sep 25, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

Relaunching tests.

@emcbot emcbot added the CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa label Sep 25, 2025
@DavidHuber-NOAA DavidHuber-NOAA removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa labels Sep 25, 2025
@emcbot emcbot added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Sep 25, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

Some tests failed on Hera and Ursa due to too many running processes. I've relaunched these on GitLab.

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress labels Sep 26, 2025
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA This PR is ready to merge. Please just merge in develop and update the gdas hash to NOAA-EMC/GDASApp@77f286d.

@xincjin-NOAA
Copy link
Copy Markdown
Contributor Author

@DavidHuber-NOAA I merged develop and go into sorc gdas.cd, checkout out 77f286d then I

git add sorc/gdas.cd
git commit -m "Update gdas.cd  to commit 77f286d"
git push

Are this correct steps?

it seems not update the hash for the gdas.cd

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@xincjin-NOAA Yes, those are the correct steps. The hash is one commit newer than you had before. This is following the update in #4105 that updated the GDASApp hash.

Merging now.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 0e6d9a0 into NOAA-EMC:develop Sep 29, 2025
5 checks passed
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Oct 8, 2025
…into feature/adjust_tasks_per_node_layout

* 'develop' of github.com:NOAA-EPIC/global-workflow-cloud:
  Adding workflow infrastructure for wave_stat and wave_stat_pnt jobs (NOAA-EMC#3846)
  Add ush and parm of SPOC (NOAA-EMC#3944)
  Bugfixes from IMS C++ code additions (NOAA-EMC#4105)
  Increase C96 gcdas fcst wall time to 1.5 hours (NOAA-EMC#4108)
  Use default stochastic physics (NOAA-EMC#4073)
  Fix new feature template (NOAA-EMC#4104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully JEDI Feature development to support JEDI-based DA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate SPOC into the ush and parm directories within global-workflow

7 participants