Add ush and parm of SPOC#3944
Conversation
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
@xincjin-NOAA I think we need to include a GDASApp hash change in here
|
@CoryMartin-NOAA added here and above: |
|
@CoryMartin-NOAA Updated the hash for the gdas.cd submodule. |
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Looks good, but since it updates GDAS hash, we probably need to wait for other PRs to go in first, like #3798
|
@xincjin-NOAA Now that #3798 has been merged, we can begin testing this PR once the conflicting GDASApp hash is resolved. Would you be able to do that? |
|
@DavidHuber-NOAA Xin is on leave for a few weeks, so this PR can move back in the queue unless you'd prefer that we fork from his fork and work to get this in. |
|
That's fine. We can wait for Xin to come back. I'll add the |
340525a
|
@xincjin-NOAA , is it possible to update the hash for |
|
@RussTreadon-NOAA updated the hash for sorc/gdas.cd. Thanks. |
|
Perfect! Thank you very much, @xincjin-NOAA . |
|
@xincjin-NOAA Could you please merge develop into this branch and resolve the conflict on the GDASApp hash? |
|
Relaunching tests. |
|
Some tests failed on Hera and Ursa due to too many running processes. I've relaunched these on GitLab. |
|
@xincjin-NOAA This PR is ready to merge. Please just merge in develop and update the gdas hash to NOAA-EMC/GDASApp@77f286d. |
|
@DavidHuber-NOAA I merged develop and go into sorc gdas.cd, checkout out 77f286d then I Are this correct steps? it seems not update the hash for the gdas.cd |
|
@xincjin-NOAA Yes, those are the correct steps. The hash is one commit newer than you had before. This is following the update in #4105 that updated the GDASApp hash. Merging now. |
…into feature/adjust_tasks_per_node_layout * 'develop' of github.com:NOAA-EPIC/global-workflow-cloud: Adding workflow infrastructure for wave_stat and wave_stat_pnt jobs (NOAA-EMC#3846) Add ush and parm of SPOC (NOAA-EMC#3944) Bugfixes from IMS C++ code additions (NOAA-EMC#4105) Increase C96 gcdas fcst wall time to 1.5 hours (NOAA-EMC#4108) Use default stochastic physics (NOAA-EMC#4073) Fix new feature template (NOAA-EMC#4104)
Description
This PR resolves issue #3943
This PR adds the capability to process python scripts and yaml files from SPOC (https://github.com/NOAA-EMC/spoc) so that GDASApp can use them to convert observation files into IODA formal.
The dependent GDASApp PR has been merged.
Resolves #3943
Type of change
Change characteristics
How has this been tested?
Checklist