Use default stochastic physics#4073
Merged
Merged
Conversation
This reverts commit d3b61f0.
Contributor
|
@EricSinsky-NOAA - I see that this PR is still a draft. Is this just because we need testing or something else? We've pulled this change into the testing we're preparing to do for the next update of experiments, so just wanted to check in on this PR and see why it was still a draft. |
Contributor
Author
Preliminary testing has finished. Marking this PR as ready for review. |
EricSinsky-NOAA
requested review from
aerorahul and
junwang-noaa
as code owners
aerorahul
approved these changes
Sep 23, 2025
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
lgtm. did not test or validate if these are acceptable to the GFS, GEFS, SFS project requirements.
Contributor
|
@dpsarmie Can you also review please? |
bingfu-NOAA
approved these changes
Sep 23, 2025
Contributor
|
These changes look fine to me and shouldn't cause any issues. These changes are also being adopted in ufs-community/ufs-weather-model#2889 but that will not change the GW setup when that UFS hash is brought in. |
JessicaMeixner-NOAA
approved these changes
Sep 23, 2025
NeilBarton-NOAA
approved these changes
Sep 23, 2025
EricSinsky-NOAA
changed the title
CatherineThomas-NOAA
approved these changes
Sep 23, 2025
Contributor
|
@EricSinsky-NOAA Have your tests completed on WCOSS2? |
Contributor
Author
|
@DavidHuber-NOAA All jobs passed on WCOSS2 except for the prepoceanobs tasks. I do not believe the prepoceanobs failures are related to the changes made in this PR though. I have merged the latest EMC/develop and am relaunching the tests. |
Contributor
|
Thanks @EricSinsky-NOAA. I will launch a parallel test of develop on WCOSS2 for a |
Contributor
Author
|
@DavidHuber-NOAA The |
Contributor
Author
|
All tests on WCOSS2 passed. |
DavidHuber-NOAA
added
the
CI-Wcoss2-Passed
Contributor
|
Thanks for running the tests on WCOSS2 @EricSinsky-NOAA! Merging. |
weihuang-jedi
added a commit
to NOAA-EPIC/global-workflow-cloud
that referenced
this pull request
Oct 8, 2025
…into feature/adjust_tasks_per_node_layout * 'develop' of github.com:NOAA-EPIC/global-workflow-cloud: Adding workflow infrastructure for wave_stat and wave_stat_pnt jobs (NOAA-EMC#3846) Add ush and parm of SPOC (NOAA-EMC#3944) Bugfixes from IMS C++ code additions (NOAA-EMC#4105) Increase C96 gcdas fcst wall time to 1.5 hours (NOAA-EMC#4108) Use default stochastic physics (NOAA-EMC#4073) Fix new feature template (NOAA-EMC#4104)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
spptint,skebintandshumintto the default values of those used in production GFSv16.Resolves #3901
Type of change
Change characteristics
Is this a breaking change (a change in existing functionality)? YES/NO
Does this change require a documentation update? YES/NO
Does this change require an update to any of the following submodules? NO
How has this been tested?
All offline CI tests passed on WCOSS2.
Checklist