STY: Remove empty __init.py__ files.#3691
Merged
Merged
Conversation
This shouldn't affect anything.
DWesl
requested review from
DavidHuber-NOAA,
KateFriedman-NOAA,
WalterKolczynski-NOAA and
aerorahul
as code owners
aerorahul
approved these changes
May 14, 2025
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Good catch.
Seems like a typo to me.
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
May 14, 2025
…path_usage * origin/develop: STY: Remove empty __init.py__ files. (NOAA-EMC#3691) Relocate config templates to `dev/` space in prep for EE2 (NOAA-EMC#3684)
tsga
added a commit
to tsga/global-workflow
that referenced
this pull request
May 15, 2025
* develop: Move parm/config/sfs/config.globus to dev/parm/config/sfs (NOAA-EMC#3697) Add Fit2Obs to modulefiles/module_base.noaacloud.lua (NOAA-EMC#3695) Update AWS defaults for running obs prep jobs on cloud (NOAA-EMC#3681) Add GCAFS forecast-only mode to the workflow Adds marine DA ensstat files to archiving (NOAA-EMC#3631) Migrate to mercury for globus/hpss transfers from MSU (NOAA-EMC#3655) STY: Remove empty __init.py__ files. (NOAA-EMC#3691) Relocate config templates to `dev/` space in prep for EE2 (NOAA-EMC#3684)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#777 added
__init.py__files, which I think were meant to be__init__.pyfiles to change Python's import behavior. Since the tests have been passing, Python doesn't seem to need these files, and I don't see another reason to keep them.Resolves #3661
Type of change
Change characteristics
How has this been tested?
No tests, yet. I'm not sure how to test ecFlow, as I understand it is an alternative to rocoto
Checklist