Skip to content

Relocate config templates to dev/ space in prep for EE2#3684

Merged
aerorahul merged 11 commits into
NOAA-EMC:developfrom
aerorahul:feature/ee2-configs
May 14, 2025
Merged

Relocate config templates to dev/ space in prep for EE2#3684
aerorahul merged 11 commits into
NOAA-EMC:developfrom
aerorahul:feature/ee2-configs

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul commented May 13, 2025 •
edited
Loading

Description

When the release is created for GFS (or any other system), parm/config will contain along with gfs, folders for gefs and sfs. This is dead code as far as operations of the GFS is concerned.

This PR:

  • relocates parm/config/gfs|gefs|sfs into dev/parm/config/gfs|gefs|sfs
  • updates setup_expt.py so that the configdir option defaults to the new location
  • updates the included yamls to the relocated path
  • updates the documentation to reflect this change
  • updates affected configs to resolve shellcheck errors

In addition to the above, this PR:

  • updates the yamls in the sfs to include the defaults provided in dev/parm/config/sfs/yaml/defaults.yaml. Previously, they were duplicated in the sfs test yaml
  • relocates a anlstat yaml that was misplaced in parm/config/gfs/yaml. Its correct place is in parm/gdas

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Created experiment directories for each of the CI cases and compared w/ develop

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

KateFriedman-NOAA
KateFriedman-NOAA suggested changes May 13, 2025
View reviewed changes
Comment thread dev/ci/cases/yamls/gfs_defaults_ci.yaml Outdated
@aerorahul
Copy link
Copy Markdown
Contributor Author

aerorahul commented May 13, 2025

@KateFriedman-NOAA @DavidHuber-NOAA
shellnorms check is failing because the differential linter thinks these are new files, as opposed to just moves.
I can open a follow-up PR to fix the linter raised issues if you would like. I would rather not make significant code changes in this PR that simply relocates files.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

KateFriedman-NOAA commented May 13, 2025

I can open a follow-up PR to fix the linter raised issues if you would like.

That works for me, thanks @aerorahul !

KateFriedman-NOAA
KateFriedman-NOAA previously approved these changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @aerorahul !

@aerorahul aerorahul mentioned this pull request May 13, 2025
Closed
11 tasks
DavidHuber-NOAA
DavidHuber-NOAA previously approved these changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

aerorahul and others added 2 commits May 13, 2025 15:34
@aerorahul @DavidHuber-NOAA
Apply suggestions from code review
86704b0 
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
@aerorahul
Merge branch 'feature/ee2-configs-shellnorms' into feature/ee2-configs
d91d594
KateFriedman-NOAA
KateFriedman-NOAA approved these changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @aerorahul !

DavidHuber-NOAA
DavidHuber-NOAA approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @aerorahul.

@aerorahul aerorahul merged commit d388e3f into NOAA-EMC:develop May 14, 2025
6 checks passed
@aerorahul aerorahul deleted the feature/ee2-configs branch May 14, 2025 13:24
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request May 14, 2025
@KateFriedman-NOAA
Merge remote-tracking branch 'origin/develop' into feature/remove_com…
fe747e9 
…path_usage

* origin/develop:
  STY: Remove empty __init.py__ files. (NOAA-EMC#3691)
  Relocate config templates to `dev/` space in prep for EE2 (NOAA-EMC#3684)
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request May 14, 2025
Merged
12 tasks
tsga added a commit to tsga/global-workflow that referenced this pull request May 15, 2025
@tsga
Merge branch 'develop' into soil_iau
417823a 
* develop:
  Move parm/config/sfs/config.globus to dev/parm/config/sfs (NOAA-EMC#3697)
  Add Fit2Obs to modulefiles/module_base.noaacloud.lua (NOAA-EMC#3695)
  Update AWS defaults for running obs prep jobs on cloud (NOAA-EMC#3681)
  Add GCAFS forecast-only mode to the workflow
  Adds marine DA ensstat files to archiving (NOAA-EMC#3631)
  Migrate to mercury for globus/hpss transfers from MSU (NOAA-EMC#3655)
  STY: Remove empty __init.py__ files. (NOAA-EMC#3691)
  Relocate config templates to `dev/` space in prep for EE2 (NOAA-EMC#3684)
This was referenced May 15, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

+1 more reviewer

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aerorahul @KateFriedman-NOAA @DavidHuber-NOAA