Skip to content

Adds marine DA ensstat files to archiving#3631

Merged
DavidHuber-NOAA merged 8 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/arch-marine-ensstat
May 14, 2025
Merged

Adds marine DA ensstat files to archiving#3631
DavidHuber-NOAA merged 8 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/arch-marine-ensstat

Conversation

@AndrewEichmann-NOAA
Copy link
Copy Markdown
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented May 1, 2025 •
edited
Loading

Adds bg_ensvar files from marine DA ensstat to archiving

Resolves rest of NOAA-EMC/GDASApp#1561

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

  • Cycled test of C48mx500_hybAOWCDA with three ensemble members on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review May 2, 2025 16:56
DavidHuber-NOAA
DavidHuber-NOAA reviewed May 2, 2025
View reviewed changes
Comment thread parm/archive/enkf.yaml.j2
@DavidHuber-NOAA DavidHuber-NOAA merged commit efeca86 into NOAA-EMC:develop May 14, 2025
5 checks passed
tsga added a commit to tsga/global-workflow that referenced this pull request May 15, 2025
@tsga
Merge branch 'develop' into soil_iau
417823a 
* develop:
  Move parm/config/sfs/config.globus to dev/parm/config/sfs (NOAA-EMC#3697)
  Add Fit2Obs to modulefiles/module_base.noaacloud.lua (NOAA-EMC#3695)
  Update AWS defaults for running obs prep jobs on cloud (NOAA-EMC#3681)
  Add GCAFS forecast-only mode to the workflow
  Adds marine DA ensstat files to archiving (NOAA-EMC#3631)
  Migrate to mercury for globus/hpss transfers from MSU (NOAA-EMC#3655)
  STY: Remove empty __init.py__ files. (NOAA-EMC#3691)
  Relocate config templates to `dev/` space in prep for EE2 (NOAA-EMC#3684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

+1 more reviewer

@shlyaeva shlyaeva shlyaeva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndrewEichmann-NOAA @guillaumevernieres @shlyaeva @DavidHuber-NOAA