Fix paths in prepocnobs task#2459
Merged
aerorahul merged 26 commits intoApr 12, 2024
Merged
Conversation
Contributor
Author
guillaumevernieres
approved these changes
Apr 4, 2024
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @AndrewEichmann-NOAA
aerorahul
requested changes
Apr 5, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
A few items to address.
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
aerorahul
reviewed
Apr 5, 2024
aerorahul
reviewed
Apr 5, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
If the issue is to fix paths in prepocenobs task, then perhaps it would be great if all paths in the config.prepoceanobs use PARMgfs instead of referring the parm files from sorc/gdas.cd.
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
aerorahul
reviewed
Apr 5, 2024
aerorahul
reviewed
Apr 5, 2024
aerorahul
reviewed
Apr 5, 2024
Contributor
Author
|
@aerorahul @WalterKolczynski-NOAA @guillaumevernieres should be good to go |
guillaumevernieres
approved these changes
Apr 9, 2024
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @AndrewEichmann-NOAA
guillaumevernieres
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Apr 12, 2024
In anticipation of the merging of NOAA-EMC/global-workflow#2459 , the `test_gdasapp_soca_setup_obsprep` ctest which sets up for `test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS` now runs the global-workflow `sorc/link_workflow.sh` script to allow the observation config files to be accessed in a global-workflow-compliant way. Effectively addresses #1032
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 15, 2024
* upstream/develop: Update fbwind for COM refactor (NOAA-EMC#2479) Update parm files for atm product (NOAA-EMC#2486) Fix paths in prepocnobs task (NOAA-EMC#2459) Add oceanalecn to workflow generator (NOAA-EMC#2409) Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478) Improve error messaging to resolve bugzilla (NOAA-EMC#2468) Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
DavidNew-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
In anticipation of the merging of NOAA-EMC/global-workflow#2459 , the `test_gdasapp_soca_setup_obsprep` ctest which sets up for `test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS` now runs the global-workflow `sorc/link_workflow.sh` script to allow the observation config files to be accessed in a global-workflow-compliant way. Effectively addresses #1032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes path for exglobal_prep_ocean_obs.py in jobs/JGLOBAL_PREP_OCEAN_OBS and associated config file
Fixes #2353, replaces PR #2356
Will break GDASApp ctests if g-w link script not run first, this will be amended in GDASApp
Type of change
Change characteristics
How has this been tested?
GDASApp global-workflow ctests on Hera
Checklist