Run g-w linker script before ctest for prepoceanobs task#1034
Merged
Conversation
AndrewEichmann-NOAA
requested review from
CoryMartin-NOAA,
apchoiCMD and
guillaumevernieres
guillaumevernieres
previously approved these changes
Apr 10, 2024
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Seems fine to me.
apchoiCMD
previously approved these changes
Apr 10, 2024
AndrewEichmann-NOAA
dismissed stale reviews from apchoiCMD and guillaumevernieres
via
35b6bf3
apchoiCMD
approved these changes
Apr 10, 2024
guillaumevernieres
added
hera-GW-RT
emcbot
added
orion-GW-RT-Running
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Failed
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Failed
guillaumevernieres
approved these changes
Apr 12, 2024
danholdaway
added a commit
that referenced
this pull request
Apr 15, 2024
* upstream/develop: remove seviri from gdas_prototype_3d yaml (#1043) Fix GW jjob tests for upcoming GW PR #2420 (#1041) Fix test output for fv3jedi_fv3inc.h (#1039) Run g-w linker script before ctest for prepoceanobs task (#1034) Update femps and fv3-jedi-lm (#1036) Add ability for JEDI-to-FV3 increment converter to process ensembles (#1022) Add AVHRR/NOAA-15/18/19 assimilation to end-to-end GDASApp validation (#997) Catch error when trying to copy missing obs files from DATA to ROTDIR in prepoceanobs (#1028)
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
In anticipation of the merging of NOAA-EMC/global-workflow#2459 , the `test_gdasapp_soca_setup_obsprep` ctest which sets up for `test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS` now runs the global-workflow `sorc/link_workflow.sh` script to allow the observation config files to be accessed in a global-workflow-compliant way. Effectively addresses #1032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anticipation of the merging of NOAA-EMC/global-workflow#2459 , the
test_gdasapp_soca_setup_obsprepctest which sets up fortest_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBSnow runs the global-workflowsorc/link_workflow.shscript to allow the observation config files to be accessed in a global-workflow-compliant way.Effectively addresses #1032