Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list#2471
Merged
aerorahul merged 4 commits intoApr 9, 2024
Merged
Conversation
7 tasks
aerorahul
requested changes
Apr 8, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Thank you for adding the conditional. This will work.
However, in config.base, the variable is named DO_JEDILANDDA. It should be renamed to DO_JEDISNOWDA. Would you mind changing that variable as well to be DO_JEDISNOWDA instead of DO_JEDILANDDA?
| echo "${COM_SNOW_ANALYSIS/${ROTDIR}\//}/*0000.sfc_data.tile4.nc" | ||
| echo "${COM_SNOW_ANALYSIS/${ROTDIR}\//}/*0000.sfc_data.tile5.nc" | ||
| echo "${COM_SNOW_ANALYSIS/${ROTDIR}\//}/*0000.sfc_data.tile6.nc" | ||
| if [[ ${DO_JEDISNOWDA} = "YES" ]]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [[ ${DO_JEDISNOWDA} = "YES" ]]; then | |
| if [[ "${DO_JEDISNOWDA:-}" == "YES" ]]; then |
Contributor
Author
There was a problem hiding this comment.
Thanks @aerorahul and done the changes as suggested.
Contributor
Author
There was a problem hiding this comment.
Also changed the DO_JEDILANDDA to DO_JEDISNOWDA.
aerorahul
approved these changes
Apr 9, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
looks good.
At somepoint we should review what needs to be archived for the sfc_data files. We have sfcanl_data tile files also being archived.
WalterKolczynski-NOAA
approved these changes
Apr 9, 2024
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 15, 2024
* upstream/develop: Update fbwind for COM refactor (NOAA-EMC#2479) Update parm files for atm product (NOAA-EMC#2486) Fix paths in prepocnobs task (NOAA-EMC#2459) Add oceanalecn to workflow generator (NOAA-EMC#2409) Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478) Improve error messaging to resolve bugzilla (NOAA-EMC#2468) Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
bbakernoaa
pushed a commit
to bbakernoaa/global-workflow
that referenced
this pull request
Mar 19, 2026
* UFSWM - Port UFS-WM to Ursa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR added checking the DO_JEDISNOWDA condition before adding snow DA analysis to the archive list.
Resolves #2469
Type of change
Change characteristics
Checklist