Skip to content

Remove debug print statements#705

Merged
WenMeng-NOAA merged 5 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:reduce_debug_prints
May 30, 2023
Merged

Remove debug print statements#705
WenMeng-NOAA merged 5 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:reduce_debug_prints

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Contributor

Reduce the amount of data being printed to stdout by removing debug print statements. Related to ufs-community/ufs-weather-model#1738

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. labels May 24, 2023
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Please sync your branch with the latest UPP develop.

@DusanJovic-NOAA
Copy link
Copy Markdown
Contributor Author

@DusanJovic-NOAA Please sync your branch with the latest UPP develop.

Done

Comment thread sorc/ncep_post.fd/WRFPOST.f
Comment thread sorc/ncep_post.fd/PROCESS.f
@WenMeng-NOAA WenMeng-NOAA added the bug Something isn't working label May 30, 2023
@WenMeng-NOAA WenMeng-NOAA linked an issue May 30, 2023 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@FernandoAndrade-NOAA Please conduct the UPP RT tests on Hera and Orion.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Contributor

FernandoAndrade-NOAA commented May 30, 2023

@WenMeng-NOAA UPP RTs have finished on Hera and Orion with no changes to results.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA UPP RTs have finished on Hera and Orion with no changes to results.

@FernandoAndrade-NOAA Please go head to approve this PR.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2 without changed results.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label May 30, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit b76d587 into NOAA-EMC:develop May 30, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the reduce_debug_prints branch September 15, 2023 11:57
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
…sics, and string length mismatch in dycore plus PR NOAA-EMC#705 and NOAA-EMC#699 (NOAA-EMC#695)

* GFDL_atmos_cubed_sphere: consistent string lengths in array

* stop FV3_HRRR_c3 from crashing with gnu debug

* in dycore, initialize srf_wnd_var2 and tracers_var3 arrays

* Write netcdf axis variables using the same real kind as data variables

* "GF radar reflectivity, dust bug fix, C3 updates, more fluxes output"

* Fix race condition in GFS_phys_time_vary.fv3.F90 error detection

* More bug fixes to GFS_phys_time_vary.fv3.F90:
1. detect empty errmsg from subroutines
2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90

* initialize errmsg & errflg in noahmp_tables.f90

* only read h2odata, ozdata and noahmp table when they are needed

* remove all constant 3D variables from clm lake

* calculate clm lake constants only once per i loop

---------

Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: fileNameFlat is not namelist configurable.

4 participants