Enabling GSL p-type, winter QPF and buckets, and lightning threat indices for RRFS#695
Conversation
EricJames-NOAA
changed the title
|
@EricJames-NOAA Can you provide me the sample RRFS model files for my testing? |
I copied some test files here on Hera: /scratch1/BMC/wrfruc/ejames/wen_ptype/ |
|
@EricJames-NOAA Thanks! |
|
Yes, these fields were committed in January or February with the rest of the winter weather changes.Eric
-------- Original message --------From: WenMeng-NOAA ***@***.***> Date: 4/21/23 9:10 PM (GMT-05:00) To: NOAA-EMC/UPP ***@***.***> Cc: ericaligo-NOAA ***@***.***>, Mention ***@***.***> Subject: Re: [NOAA-EMC/UPP] Enabling GSL p-type, winter QPF and buckets, and lightning threat indices for RRFS (PR #695)
@WenMeng-NOAA commented on this pull request.
In parm/fv3lam_rrfs.xml:
+
+ <param>
+ <shortname>BUCKET_SNOWFALL_ON_SURFACE</shortname>
+ <scale>6.0</scale>
+ </param>
+
+ <param>
+ <shortname>BUCKET_GRAUPEL_ON_SURFACE</shortname>
+ <scale>6.0</scale>
+ </param>
+
+ <param>
+ <shortname>BUCKET_FRAIN_ON_SURFACE</shortname>
+ <scale>6.0</scale>
+ </param>
+
@EricJames-NOAA These variables were already added with @ericaligo-NOAA 's PR #600
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
MatthewPyle-NOAA
left a comment
MatthewPyle-NOAA
left a comment
There was a problem hiding this comment.
Generally looked good to me - just one question about the removal of the "MAX" for the two lightning products, and a cosmetic suggestion for code readability.
|
@EricJames-NOAA My test results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2023042020 on Hera. I see the following expected changes: values change in CRAIN, CSNOW, CICEP, CFRZR due to switching to GSL P-types. Please let me know if you see any issues. Thanks! |
@WenMeng-NOAA thanks for your test! The results look good to me! |
MatthewPyle-NOAA
left a comment
MatthewPyle-NOAA
left a comment
There was a problem hiding this comment.
Thanks @EricJames-NOAA for addressing my comments and questions. Looks good to me now.
WenMeng-NOAA
added
Baseline Change
|
@EdwardColon-NOAA Please be aware of the changes which have impact on 3DRTMA in this PR. |
|
The UPP RT tests were completed on WCOSS2, Hera and Orion. The baselines for 3DRTMA, RAP and HRRR will be recreated with this PR. |
|
@ericaligo-NOAA @MatthewPyle-NOAA Thanks for reviewing this PR. |
|
This PR is ready for merging. |
|
Hi Wen,
These changes shouldn't impact the use of 3D-RTMA.
Thanks,
Edward
…On Mon, Apr 24, 2023 at 7:59 PM WenMeng-NOAA ***@***.***> wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> @MatthewPyle-NOAA
<https://github.com/MatthewPyle-NOAA> Thanks for reviewing this PR.
—
Reply to this email directly, view it on GitHub
<#695 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFXXQAIKMC3FICRTJXOYN3XC4HULANCNFSM6AAAAAAXHBQS6I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-------------------------------------------------
Edward Colón
*Lynker* at NOAA/NWS/NCEP/EMC
5830 University Research Ct.
Rm #2025
Riverdale, MD 20737
Office: (301) 683-3815
Cell: (301) 213-3566
|
@EdwardColon-NOAA Thanks for confirming. |
…sics, and string length mismatch in dycore plus PR NOAA-EMC#705 and NOAA-EMC#699 (NOAA-EMC#695) * GFDL_atmos_cubed_sphere: consistent string lengths in array * stop FV3_HRRR_c3 from crashing with gnu debug * in dycore, initialize srf_wnd_var2 and tracers_var3 arrays * Write netcdf axis variables using the same real kind as data variables * "GF radar reflectivity, dust bug fix, C3 updates, more fluxes output" * Fix race condition in GFS_phys_time_vary.fv3.F90 error detection * More bug fixes to GFS_phys_time_vary.fv3.F90: 1. detect empty errmsg from subroutines 2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90 * initialize errmsg & errflg in noahmp_tables.f90 * only read h2odata, ozdata and noahmp table when they are needed * remove all constant 3D variables from clm lake * calculate clm lake constants only once per i loop --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
6 participants
This PR switches to the GSL precip type algorithm for RRFS, introduces new winter QPF output (TSNOWP, FRZR, FROZR, both run total accumulated and 1-h accumulated), and enables output of the three GSL lightning threat diagnostics.
The changes were tested retrospectively for the RRFS-B (3km CONUS) system on Jet.