Skip to content

Remove debug print statements #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 5 commits into from
May 30, 2023
Merged

Remove debug print statements #705

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8f91df
Remove debug print statements
DusanJovic-NOAA May 9, 2023
6849d94
Merge branch 'develop' into reduce_debug_prints
DusanJovic-NOAA May 25, 2023
8d3255a
Revert sorc/ncep_post.fd/PROCESS.f
DusanJovic-NOAA May 26, 2023
dccad7f
Print the namelists read in to stdout
DusanJovic-NOAA May 26, 2023
110967d
Remove more debug prints (from Wen Meng)
DusanJovic-NOAA May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions sorc/ncep_post.fd/CALVIS_GSD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,6 @@ SUBROUTINE CALVIS_GSD(CZEN,VIS)
BETAV = BETAV + aextc55(i,j,lm)*1000.
endif

if (i==290 .and. j==112) then
write (6,*) 'BETAV, extcof55 =',BETAV,extcof55(i,j,lm)
end if

! Calculation of visibility based on hydrometeor and aerosols. (RH effect not yet included.)
VIS(I,J)=MIN(90.,CONST1/(BETAV+extcof55(i,j,lm))) ! max of 90km

Expand All @@ -329,16 +325,8 @@ SUBROUTINE CALVIS_GSD(CZEN,VIS)
vis_night = 1.69 * ((vis(i,j)/1.609)**0.86) * 1.609

zen_fac = min(0.1,max(czen(i,j),0.))/ 0.1
if (i==290 .and. j==112) then
write (6,*) 'zen_fac,vis_night, vis =',zen_fac,vis_night, vis(i,j)
end if

vis(i,j) = zen_fac * vis(i,j) + (1.-zen_fac)*vis_night

if (i==290 .and. j==112) then
write (6,*) 'visrh, vis =',visrh, vis(i,j)
end if

if(method == 1 .or. method == 3)then ! RH method (if lower vis)
vis(i,j) = min(vis(i,j),visrh)
endif
Expand Down
9 changes: 0 additions & 9 deletions sorc/ncep_post.fd/MDL2P.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ SUBROUTINE MDL2P(iostatusD3D)
!
! START MDL2P.
!
if(me==0) print*, 'MDL2P SMFLAG=',SMFLAG

if (modelname == 'GFS') then
zero = 0.0
else
Expand Down Expand Up @@ -3948,12 +3946,8 @@ SUBROUTINE MDL2P(iostatusD3D)
! OUTPUT MEMBRANCE SLP
IF(IGET(023) > 0)THEN
IF(gridtype == 'A'.OR. gridtype == 'B') then
if(me==0)PRINT*,'CALLING MEMSLP for A or B grid'
CALL MEMSLP(TPRS,QPRS,FPRS)
if(me==0)PRINT*,'aft CALLING MEMSLP for A or B grid,pslp=', &
maxval(pslp(ista:iend,jsta:jend)),minval(pslp(ista:iend,jsta:jend)),pslp((ista+iend)/2,(jsta+jend)/2)
ELSE IF (gridtype == 'E')THEN
if(me==0)PRINT*,'CALLING MEMSLP_NMM for E grid'
! CALL MEMSLP_NMM(TPRS,QPRS,FPRS)
ELSE
PRINT*,'unknow grid type-> WONT DERIVE MESINGER SLP'
Expand Down Expand Up @@ -3982,7 +3976,6 @@ SUBROUTINE MDL2P(iostatusD3D)

! OUTPUT of MAPS SLP
IF(IGET(445) > 0)THEN
if(me==0)PRINT*,'CALLING MAPS SLP'
CALL MAPSSLP(TPRS)
!$omp parallel do private(i,j)
DO J=JSTA,JEND
Expand Down Expand Up @@ -4080,7 +4073,6 @@ SUBROUTINE MDL2P(iostatusD3D)

! SNOW DESITY SOLID-LIQUID-RATION SLR
IF ( IGET(1006)>0 ) THEN
if(me==0)PRINT*,'CALLING SLR'
egrid1=spval
if(slrutah_on) then
call calslr_uutah(EGRID1)
Expand Down Expand Up @@ -4118,7 +4110,6 @@ SUBROUTINE MDL2P(iostatusD3D)
if(allocated(smokesl)) deallocate(smokesl)
if(allocated(fv3dustsl)) deallocate(fv3dustsl)
if(allocated(coarsepmsl)) deallocate(coarsepmsl)
if(me==0)PRINT*,'MDL2P completed'
! END OF ROUTINE.
!
RETURN
Expand Down
79 changes: 0 additions & 79 deletions sorc/ncep_post.fd/MDL2THANDPV.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
!******************************************************************************
!
! START MDL2TH.
!
if(me==0) write(*,*) 'MDL2THANDPV starts'
!
! SET TOTAL NUMBER OF POINTS ON OUTPUT GRID.
!
Expand Down Expand Up @@ -364,31 +362,11 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
END DO
END IF


IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC INPUT ', &
'p,dpdx,dpdy,tv,dtdx,dtdy,h,u,v,vort= '
DO L=1,LM
print*,pmid(i,j,l),dum1d1(l),dum1d2(l),dum1d5(l) &
,dum1d3(l),dum1d4(l),zmid(i,j,l),uh(i,j,l),vh(i,j,l) &
,dum1d6(l),L
end do
end if

CALL PVETC(LM,PMID(I,J,1:LM),DUM1D1,DUM1D2 &
,DUM1D5,DUM1D3,DUM1D4,ZMID(I,J,1:LM),UH(I,J,1:LM) &
,VH(I,J,1:LM),DUM1D6 &
,DUM1D7,DUM1D8,DUM1D9,DUM1D10,DUM1D11,DUM1D12,DUM1D13)!output

IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC OUTPUT ' &
,'hm,s,bvf2,pvn,theta,sigma,pvu= '
DO L=1,LM
print*,dum1d7(l),dum1d8(l),dum1d9(l),dum1d10(l),dum1d11(l) &
,dum1d12(l),dum1d13(l),L
end do
end if

IF((IGET(332) > 0).OR.(IGET(333) > 0).OR. &
(IGET(334) > 0).OR.(IGET(335) > 0).OR. &
(IGET(351) > 0).OR.(IGET(352) > 0).OR. &
Expand Down Expand Up @@ -443,31 +421,11 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
& + F(I,J)
END DO

IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC INPUT for regional ', &
'p,dpdx,dpdy,tv,dtdx,dtdy,h,u,v,vort ', &
'JSTA_m,Jend_m, L= '
DO L=1,LM
print*,pmid(i,j,l),dum1d1(l),dum1d2(l),dum1d5(l) &
,dum1d3(l),dum1d4(l),zmid(i,j,l),uh(i,j,l),vh(i,j,l) &
,dum1d6(l),JSTA_m,Jend_m,L
end do
end if

CALL PVETC(LM,PMID(I,J,1:LM),DUM1D1,DUM1D2 &
,DUM1D5,DUM1D3,DUM1D4,ZMID(I,J,1:LM),UH(I,J,1:LM) &
,VH(I,J,1:LM),DUM1D6 &
,DUM1D7,DUM1D8,DUM1D9,DUM1D10,DUM1D11,DUM1D12,DUM1D13)!output

IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC OUTPUT ' &
,'hm,s,bvf2,pvn,theta,sigma,pvu,pvort= '
DO L=1,LM
print*,dum1d7(l),dum1d8(l),dum1d9(l),dum1d10(l),dum1d11(l) &
,dum1d12(l),dum1d13(l),DUM1D6(l),L
end do
end if

IF((IGET(332) > 0).OR.(IGET(333) > 0).OR. &
(IGET(334) > 0).OR.(IGET(335) > 0).OR. &
(IGET(351) > 0).OR.(IGET(352) > 0).OR. &
Expand Down Expand Up @@ -538,29 +496,11 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)

END DO

! IF(I==IM/2 .AND. J==JM/2)then
! PRINT*,'SAMPLE PVETC INPUT ' &
! ,'p,dpdx,dpdy,tv,dtdx,dtdy,h,u,v,vort= '
! DO L=1,LM
! print*,pmid(i,j,l),dum1d1(l),dum1d2(l),dum1d5(l) &
! ,dum1d3(l),dum1d4(l),zmid(i,j,l),uh(i,j,l),vh(i,j,l) &
! ,dum1d6(l)
! end do
! end if

CALL PVETC(LM,PMID(I,J,1:LM),DUM1D1,DUM1D2 &
,DUM1D5,DUM1D3,DUM1D4,ZMID(I,J,1:LM),UH(I,J,1:LM) &
,VH(I,J,1:LM),DUM1D6 &
,DUM1D7,DUM1D8,DUM1D9,DUM1D10,DUM1D11,DUM1D12,DUM1D13)!output

! IF(I==IM/2 .AND. J==JM/2)then
! PRINT*,'SAMPLE PVETC OUTPUT ' &
! ,'hm,s,bvf2,pvn,theta,sigma,pvu= '
! DO L=1,LM
! print*,dum1d7(l),dum1d8(l),dum1d9(l),dum1d10(l),dum1d11(l) &
! ,dum1d12(l),dum1d13(l)
! end do
! end if
IF((IGET(332)>0).OR.(IGET(333)>0).OR. &
(IGET(334)>0).OR.(IGET(335)>0).OR. &
(IGET(351)>0).OR.(IGET(352)>0).OR. &
Expand Down Expand Up @@ -615,29 +555,11 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
DUM1D6(L)=DVDX-DUDY+F(I,J)+UAVG*TAN(TPHI)/ERAD !vort
END DO

IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC INPUT ' &
,'p,dpdx,dpdy,tv,dtdx,dtdy,h,u,v,vort= '
DO L=1,LM
print*,pmid(i,j,l),dum1d1(l),dum1d2(l),dum1d5(l) &
,dum1d3(l),dum1d4(l),zmid(i,j,l),uh(i,j,l),vh(i,j,l) &
,dum1d6(l)
end do
end if

CALL PVETC(LM,PMID(I,J,1:LM),DUM1D1,DUM1D2 &
,DUM1D5,DUM1D3,DUM1D4,ZMID(I,J,1:LM),UH(I,J,1:LM) &
,VH(I,J,1:LM),DUM1D6 &
,DUM1D7,DUM1D8,DUM1D9,DUM1D10,DUM1D11,DUM1D12,DUM1D13)!output

IF(I==IM/2 .AND. J==JM/2)then
PRINT*,'SAMPLE PVETC OUTPUT ' &
,'hm,s,bvf2,pvn,theta,sigma,pvu= '
DO L=1,LM
print*,dum1d7(l),dum1d8(l),dum1d9(l),dum1d10(l),dum1d11(l) &
,dum1d12(l),dum1d13(l)
end do
end if
IF((IGET(332) > 0).OR.(IGET(333) > 0).OR. &
(IGET(334) > 0).OR.(IGET(335) > 0).OR. &
(IGET(351) > 0).OR.(IGET(352) > 0).OR. &
Expand Down Expand Up @@ -1174,7 +1096,6 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
DUM1D14,wrk1, wrk2, wrk3, wrk4, cosl, dum2d)

END IF ! end of selection for isentropic and constant PV fields
if(me==0) write(*,*) 'MDL2THANDPV ends'
!
!
! END OF ROUTINE.
Expand Down
19 changes: 0 additions & 19 deletions sorc/ncep_post.fd/MDLFLD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ SUBROUTINE MDLFLD
ELSE
IICE = 1
END IF
PRINT*,'IICE= ',IICE

! Chuang: add convective contribution for all MP schemes
RDTPHS=3.6E6/DTQ2
Expand Down Expand Up @@ -897,7 +896,6 @@ SUBROUTINE MDLFLD
ze_smax = 10.*log10(ze_smax*1.e18)
ze_gmax = 10.*log10(ze_gmax*1.e18)

write (6,*) 'dbze_max-r/s/g',ze_rmax,ze_smax,ze_gmax
ENDIF !tgs endif for Thompson scheme

END IF
Expand Down Expand Up @@ -1750,7 +1748,6 @@ SUBROUTINE MDLFLD
ENDIF
!
! MOISTURE CONVERGENCE ON MDL SURFACES.
! write(*,*)'iget083=',iget(083),' l=',l
LLL = 0
if (IGET(083) > 0) LLL = LVLS(L,IGET(083))
IF (IGET(083)>0 .OR. IGET(295)>0) THEN
Expand Down Expand Up @@ -3884,9 +3881,6 @@ SUBROUTINE MDLFLD
EGRID6(I,J)<spval.and.EGRID7(I,J)<spval.and.&
UH(I,J,1)<spval)THEN
if (EGRID5(I,J) <= EGRID4(I,J)) then
! if (I == 50 .and. J == 50) then
! write(*,*) 'working with L : ', L
! endif
HCOUNT = HCOUNT+1
DP = EGRID6(I,J) - EGRID7(I,J)
EGRID1(I,J) = EGRID1(I,J) + UH(I,J,L)*DP
Expand Down Expand Up @@ -3971,15 +3965,9 @@ SUBROUTINE MDLFLD
ELSe
EGRID3(I,J) = SPVAL
END IF

! if (mod(I,20) == 0 .and. mod(J,20) == 0) then
! write(*,*) 'wind speed ', I,J, EGRID1(I,J)
! endif

ENDDO
ENDDO

! write(*,*) 'min, max of GRID1 (u comp transport wind): ', minval(grid1),maxval(grid1)
IF(IGET(389) > 0)THEN
if(grib=='grib2') then
cfld=cfld+1
Expand Down Expand Up @@ -4013,7 +4001,6 @@ SUBROUTINE MDLFLD

IF ( (IGET(454) > 0) ) THEN

! write(*,*) 'IM is: ', IM
!$omp parallel do private(i,j)
DO J=JSTA,JEND
DO I=ista,iend
Expand All @@ -4024,12 +4011,6 @@ SUBROUTINE MDLFLD
GRID1(I,J) = 0.
ENDIF

! if ( (I >= 15 .and. I <= 17) .and. J >= 193 .and. J <= 195) then
! write(*,*) 'I,J,EGRID1(I,J) (wind speed): ', I,J, EGRID1(I,J)
! write(*,*) 'I,J,PBLH: ', I,J, EGRID4(I,J)
! write(*,*) 'I,J,GRID1 (ventilation rate): ', I,J, GRID1(I,J)
! endif

ENDDO
ENDDO

Expand Down
15 changes: 0 additions & 15 deletions sorc/ncep_post.fd/PROCESS.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,79 +54,66 @@ SUBROUTINE PROCESS(kth,kpv,th,pv,iostatusD3D)
! START SUBROUTINE PROCESS.
!
cfld=0
if(me==0) write(*,*) "PROCESS starts"
Comment thread
DusanJovic-NOAA marked this conversation as resolved.
!
! COMPUTE/POST FIELDS ON MDL SURFACES.
!
btim = mpi_wtime()
CALL MDLFLD
if(me==0) write(*,*) "PROCESS MDLFLD done"
ETAFLD2_tim = ETAFLD2_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST FIELDS ON PRESSURE SURFACES.
btim = mpi_wtime()
CALL MDL2P(iostatusD3D)
if(me==0) write(*,*) "PROCESS MDL2P done"
ETA2P_tim = ETA2P_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST FIELDS ON SIGMA SURFACES.
btim = mpi_wtime()
CALL MDL2SIGMA
if(me==0) write(*,*) "PROCESS MDL2SIGMA done"
CALL MDL2SIGMA2
if(me==0) write(*,*) "PROCESS MDL2SIGMA2 done"
MDL2SIGMA_tim = MDL2SIGMA_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST FIELDS ON AGL SURFCES.
btim = mpi_wtime()
CALL MDL2AGL
if(me==0) write(*,*) "PROCESS MDL2AGL done"
MDL2AGL_tim = MDL2AGL_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST SURFACE RELATED FIELDS.
btim = mpi_wtime()
CALL SURFCE
if(me==0) write(*,*) "PROCESS SURFCE done"
SURFCE2_tim = SURFCE2_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST SOUNDING AND CLOUD RELATED FIELDS.
btim = mpi_wtime()
CALL CLDRAD
if(me==0) write(*,*) "PROCESS CLDRAD done"
CLDRAD_tim = CLDRAD_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST TROPOPAUSE DATA, FD LEVEL FIELDS,
! FREEZING LEVEL HEIGHT AND RH, BOUNDARY LAYER FIELDS,
! AND LFM-NGM LOOK-ALIKE FIELDS.
btim = mpi_wtime()
CALL MISCLN
if(me==0) write(*,*) "PROCESS MISCLN done"
MISCLN_tim = MISCLN_tim +(mpi_wtime() - btim)

! COMPUTE/POST TROPOPAUSE DATA, FD LEVEL FIELDS,
! FREEZING LEVEL HEIGHT AND RH, BOUNDARY LAYER FIELDS,
! AND LFM-NGM LOOK-ALIKE FIELDS.
btim = mpi_wtime()
CALL MDL2STD_P
if(me==0) write(*,*) "PROCESS MDL2STD_P done"
MDL2STD_tim = MDL2STD_tim +(mpi_wtime() - btim)
!
! POST FIXED FIELDS.
btim = mpi_wtime()
CALL FIXED
if(me==0) write(*,*) "PROCESS FIXED done"
FIXED_tim = FIXED_tim +(mpi_wtime() - btim)
!
! COMPUTE/POST FIELDS ON SIGMA SURFACES.
btim = mpi_wtime()
CALL MDL2THANDPV(kth,kpv,th,pv)
if(me==0) write(*,*) "PROCESS MDL2THANDPV done"
MDL2THANDPV_tim = MDL2THANDPV_tim +(mpi_wtime() - btim)
!
! POST RADIANCE AND BRIGHTNESS FIELDS.
btim = mpi_wtime()
CALL CALRAD_WCLOUD
if(me==0) write(*,*) "PROCESS CALRAD_WCLOUD done"
CALRAD_WCLOUD_tim = CALRAD_WCLOUD_tim +(mpi_wtime() - btim)
!
! IN-FLIGHT ICING PRODUCTS
Expand All @@ -137,8 +124,6 @@ SUBROUTINE PROCESS(kth,kpv,th,pv,iostatusD3D)
! END OF ROUTINE.
!
NTLFLD=cfld
if(me==0)print *,'nTLFLD=',NTLFLD
if(me==0) write(*,*) "PROCESS done"
!
RETURN
END
6 changes: 0 additions & 6 deletions sorc/ncep_post.fd/READ_xml.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,9 @@ SUBROUTINE READ_xml()
! START READCNTRL_XML HERE.
!
! READ post available field table
if (me==0) write(*,*)'in readxml,bf readxml,size(post_avblflds%param)=', &
size(post_avblflds%param)
call read_postxconfig()
num_post_afld=size(paramset(1)%param)
num_pset=size(paramset)
if (me==0) write(*,*)'in readxml, aft read flat file.xml,num_post_afld=', &
num_post_afld
if (me==0) write(*,*)'in readxml, aft read flat file.xml,num_pset=',num_pset


! LinGan below line removed because now we only read one flat file
!
Expand Down
Loading