GSL precip type fix#730
Conversation
… using run total precip.
|
@EricJames-NOAA Can you sync your branch with the latest UPP develop? |
|
@WenMeng-NOAA Would you like me to go ahead and start UPP RTs on Hera and Orion for this PR? |
|
|
@EricJames-NOAA In you PR #695, P-type in PRSLEV were switched to GSL scheme. Another group of P-type generated with non-GSL scheme is kept in NATLEV dataset. I would like to know if this kind of configuration is intentional. |
@WenMeng-NOAA no that it is not intentional! I meant to switch all p-types to the GSL scheme. I can add that change into this PR. Thank you for pointing it out! |
|
I think I ran into a similar issue recently in the CI. @EricJames-NOAA can you try changing |
|
The UPP RT tests were conducted on WCOSS2. There are some changed results from 3DRTMA as: |
|
@FernandoAndrade-NOAA You may start the UPP RT tests on Hera and Orion and check if your testing is consistent with mine on WCOSS2. The fields with undefined values can be ignored, such as: 1023:990098358:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined |
|
@WenMeng-NOAA, I'm trying to resolve an account issue with the help desk for Orion/Hercules that's caused me being unable to run RTs there. Hera I should be able to run RTs for this PR |
@FernandoAndrade-NOAA I can run the RT tests on Orion. |
|
The UPP RT tests were completed on Hera. The results are consistent with ones from WCOSS2. There will be a baseline update for 3drtma with this PR. |
@EricJames-NOAA Could you add the fix based on @AlexanderRichert-NOAA 's suggestions in your branch to test this CI failure on github? |
…n from Alex Richert.
Sorry! I just committed those changes. Let's see if the tests succeed now. |
|
@EricJames-NOAA there's one more instance of |
|
@WenMeng-NOAA RTs finished on Hera with the expected changes in 3drtma PRSLEV and NATLEV, apologies for the delay |
|
@AlexanderRichert-NOAA Now the CI is successful. Thanks for the quick fix. |
|
The UPP RT tests were completed on Orion. The results are consistent with the ones on WCOSS2. |
@FernandoAndrade-NOAA Please approve this PR. |
|
This PR is ready for merging. |
* Add GCC-based CI build
Correcting GSL precip type diagnosis to use 1-h precip instead of run total precip for RRFS.
The code was tested for RRFS_3km_CONUS system on Jet.