Skip to content

GSL precip type fix#730

Merged
WenMeng-NOAA merged 6 commits into
NOAA-EMC:developfrom
EricJames-NOAA:ptype_fix
Jun 22, 2023
Merged

GSL precip type fix#730
WenMeng-NOAA merged 6 commits into
NOAA-EMC:developfrom
EricJames-NOAA:ptype_fix

Conversation

@EricJames-NOAA
Copy link
Copy Markdown
Contributor

Correcting GSL precip type diagnosis to use 1-h precip instead of run total precip for RRFS.

The code was tested for RRFS_3km_CONUS system on Jet.

@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 15, 2023 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Can you sync your branch with the latest UPP develop?

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Contributor

@WenMeng-NOAA Would you like me to go ahead and start UPP RTs on Hera and Orion for this PR?

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA Would you like me to go ahead and start UPP RTs on Hera and Orion for this PR?
@FernandoAndrade-NOAA I have been reviewing and testing for RRFS. Please hold off your testing.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA In you PR #695, P-type in PRSLEV were switched to GSL scheme. Another group of P-type generated with non-GSL scheme is kept in NATLEV dataset. I would like to know if this kind of configuration is intentional.

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@EricJames-NOAA In you PR #695, P-type in PRSLEV were switched to GSL scheme. Another group of P-type generated with non-GSL scheme is kept in NATLEV dataset. I would like to know if this kind of configuration is intentional.

@WenMeng-NOAA no that it is not intentional! I meant to switch all p-types to the GSL scheme. I can add that change into this PR. Thank you for pointing it out!

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor

I think I ran into a similar issue recently in the CI. @EricJames-NOAA can you try changing cache_key: intel2 -> cache_key: intel**3** (one place) and actions/cache@v2->actions/cache@v**3** (two places) in .github/workflows/intel.yml? If that doesn't work then I can dig further.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were conducted on WCOSS2. There are some changed results from 3DRTMA as:

NATLEV:
1371:1211459369:CSNOW:surface:rpn_corr=0.0384651:rpn_rms=0.46011
1373:1211505551:CFRZR:surface:rpn_corr=-0.000302196:rpn_rms=0.276241
1374:1211567817:CRAIN:surface:rpn_corr=0.014156:rpn_rms=0.893746

PRSLEV:
797:715173114:CFRZR:surface:rpn_corr=0.0822664:rpn_rms=0.275226
798:715235380:CRAIN:surface:rpn_corr=0.96125:rpn_rms=0.113849

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@FernandoAndrade-NOAA You may start the UPP RT tests on Hera and Orion and check if your testing is consistent with mine on WCOSS2. The fields with undefined values can be ignored, such as: 1023:990098358:ALBDO:surface:rpn_corr=-nan:rpn_rms=undefined

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Contributor

@WenMeng-NOAA, I'm trying to resolve an account issue with the help desk for Orion/Hercules that's caused me being unable to run RTs there. Hera I should be able to run RTs for this PR

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA, I'm trying to resolve an account issue with the help desk for Orion/Hercules that's caused me being unable to run RTs there. Hera I should be able to run RTs for this PR

@FernandoAndrade-NOAA I can run the RT tests on Orion.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on Hera. The results are consistent with ones from WCOSS2. There will be a baseline update for 3drtma with this PR.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

I think I ran into a similar issue recently in the CI. @EricJames-NOAA can you try changing cache_key: intel2 -> cache_key: intel**3** (one place) and actions/cache@v2->actions/cache@v**3** (two places) in .github/workflows/intel.yml? If that doesn't work then I can dig further.

@EricJames-NOAA Could you add the fix based on @AlexanderRichert-NOAA 's suggestions in your branch to test this CI failure on github?

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

I think I ran into a similar issue recently in the CI. @EricJames-NOAA can you try changing cache_key: intel2 -> cache_key: intel**3** (one place) and actions/cache@v2->actions/cache@v**3** (two places) in .github/workflows/intel.yml? If that doesn't work then I can dig further.

@EricJames-NOAA Could you add the fix based on @AlexanderRichert-NOAA 's suggestions in your branch to test this CI failure on github?

Sorry! I just committed those changes. Let's see if the tests succeed now.

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor

@EricJames-NOAA there's one more instance of actions/cache@v2 to change to v3. Fingers crossed...

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Contributor

FernandoAndrade-NOAA commented Jun 22, 2023

@WenMeng-NOAA RTs finished on Hera with the expected changes in 3drtma PRSLEV and NATLEV, apologies for the delay

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA Now the CI is successful. Thanks for the quick fix.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on Orion. The results are consistent with the ones on WCOSS2.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA RTs finished on Hera with the expected changes in 3drtma PRSLEV and NATLEV, apologies for the delay

@FernandoAndrade-NOAA Please approve this PR.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Jun 22, 2023
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 16331ae into NOAA-EMC:develop Jun 22, 2023
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
* Add GCC-based CI build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3DRTMA Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correction in GSL precip type diagnosis

4 participants