Modify visibility upper bound for GFS#1369
Conversation
WenMeng-NOAA
added
Baseline Change
|
The VIS value modification of this PR currently precedes the modification that accounts for nighttime effect (lines 378-383), which increases the VIS value in nighttime regions and may cause VIS > 24.135 km in some cases. It is suggested that the new statement be moved to line 392 (prior to the final value modification from units of km to m) to ensure that no value of VIS exceeds 24.135 km with GFS. |
@ChristopherHill-NOAA Good catching. I will modify that. |
|
@clyden-noaa This PR is ready for RTs on R&D machine. There should be a baseline change in gfs test. |
BenjaminBlake-NOAA
left a comment
BenjaminBlake-NOAA
left a comment
There was a problem hiding this comment.
@WenMeng-NOAA Your changes look good to me, and I got the expected change to GFS visibility in my testing.
clyden-noaa
left a comment
clyden-noaa
left a comment
There was a problem hiding this comment.
@WenMeng-NOAA @BenjaminBlake-NOAA
All of my testing is complete.
The gfs baseline has been updated on all HPCs
All RTs successfully ran without errors and within timing thresholds.
|
This PR is ready for merging. |
github-project-automation
Bot
moved this from Ready for Testing
to Merged
in PRs to Process
5 participants
Solve issue #1368.