Skip to content

add method_blsn to the namelist#1036

Merged
jkbk2004 merged 4 commits into
NOAA-EMC:developfrom
RuiyuSun:blsn
Dec 8, 2025
Merged

add method_blsn to the namelist#1036
jkbk2004 merged 4 commits into
NOAA-EMC:developfrom
RuiyuSun:blsn

Conversation

@RuiyuSun
Copy link
Copy Markdown
Contributor

@RuiyuSun RuiyuSun commented Nov 19, 2025

Description

This PR is to fix a bug associated with the inline UPP when the method_blsn is used in the visibility calculation in the calvis_gsd routine.

If this method is used in the inline UPP visibility calculation the results will be changed.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes noaa-emc/fv3atm/issues/<1035>

Testing

How were these changes tested? Full RT test on URSA
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) YES
Have the ufs-weather-model regression test been run? On what platform? Full RT tests were completed on URSA

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch (Committed to the UFS weather model PR)

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
NOAA-EMC/UPP#1369

Do PRs in upstream repositories need to be merged first? NO

@NickSzapiro-NOAA
Copy link
Copy Markdown
Collaborator

@RuiyuSun I think should also set default value for blsn ~ line 270 before namelist is read...as is, it will be uninitialized variable if not in the run's namelist

fwiw, default is true in https://github.com/NOAA-EMC/UPP/blob/3ed513f4216624fd466ae04b503e303a71fa05e0/sorc/ncep_post.fd/WRFPOST.F#L279

@WenMeng-NOAA
Copy link
Copy Markdown
Contributor

@RuiyuSun I think should also set default value for blsn ~ line 270 before namelist is read...as is, it will be uninitialized variable if not in the run's namelist

fwiw, default is true in https://github.com/NOAA-EMC/UPP/blob/3ed513f4216624fd466ae04b503e303a71fa05e0/sorc/ncep_post.fd/WRFPOST.F#L279

@RuiyuSun You may add a new line "method_blsn = .true." next to line 272

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

@RuiyuSun I think should also set default value for blsn ~ line 270 before namelist is read...as is, it will be uninitialized variable if not in the run's namelist
fwiw, default is true in https://github.com/NOAA-EMC/UPP/blob/3ed513f4216624fd466ae04b503e303a71fa05e0/sorc/ncep_post.fd/WRFPOST.F#L279

@RuiyuSun You may add a new line "method_blsn = .true." next to line 272

OK. Thanks @NickSzapiro-NOAA @WenMeng-NOAA

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

Can anyone help to review this change? @DusanJovic-NOAA @WenMeng-NOAA

Copy link
Copy Markdown
Contributor

@WenMeng-NOAA WenMeng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good to me.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing for the WM parent PR 2987 completed successfully. Please go ahead and merge this PR.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA @BrianCurtis-NOAA @jkbk2004 Could one of you please merge this PR?

@jkbk2004 jkbk2004 merged commit 2194b6f into NOAA-EMC:develop Dec 8, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants