add method_blsn to the namelist#1036
Conversation
|
@RuiyuSun I think should also set default value for blsn ~ line 270 before namelist is read...as is, it will be uninitialized variable if not in the run's namelist fwiw, default is true in https://github.com/NOAA-EMC/UPP/blob/3ed513f4216624fd466ae04b503e303a71fa05e0/sorc/ncep_post.fd/WRFPOST.F#L279 |
@RuiyuSun You may add a new line "method_blsn = .true." next to line 272 |
OK. Thanks @NickSzapiro-NOAA @WenMeng-NOAA |
|
Can anyone help to review this change? @DusanJovic-NOAA @WenMeng-NOAA |
WenMeng-NOAA
left a comment
There was a problem hiding this comment.
The updates look good to me.
|
Testing for the WM parent PR 2987 completed successfully. Please go ahead and merge this PR. |
|
@DusanJovic-NOAA @BrianCurtis-NOAA @jkbk2004 Could one of you please merge this PR? |
Description
This PR is to fix a bug associated with the inline UPP when the method_blsn is used in the visibility calculation in the calvis_gsd routine.
If this method is used in the inline UPP visibility calculation the results will be changed.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Full RT test on URSA
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) YES
Have the ufs-weather-model regression test been run? On what platform? Full RT tests were completed on URSA
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
NOAA-EMC/UPP#1369
Do PRs in upstream repositories need to be merged first? NO