Skip to content

Modify visibility upper bound for GFS #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 9 commits into from
Nov 21, 2025
Merged

Modify visibility upper bound for GFS #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
389fdc4
Modify visibility upper bound for GFS
WenMeng-NOAA Nov 19, 2025
afec57e
Merge remote-tracking branch 'upstream/develop' into post_vis
WenMeng-NOAA Nov 20, 2025
8e977eb
Tweak based on Chris's comments
WenMeng-NOAA Nov 20, 2025
61c19df
Merge branch 'develop' into post_vis
WenMeng-NOAA Nov 21, 2025
10a8c90
Add RT log for WCOSS2
WenMeng-NOAA Nov 21, 2025
95e435f
Ursa RT log for intel compiler
clyden-noaa Nov 21, 2025
1dceed8
Ursa RT log for intelllvm compiler
clyden-noaa Nov 21, 2025
e041234
Orion RT log for intel compiler
clyden-noaa Nov 21, 2025
0d3c0c9
Hercules RT log for intel compiler
clyden-noaa Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sorc/ncep_post.fd/CALVIS_GSD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ SUBROUTINE CALVIS_GSD(CZEN,VIS)
! calculation (extcof55 is all zeroes)
! 2024-04 Eric James - correcting bug in BLSN effect (missing factor of
! ustar_t) and removing BLSN effect for z0>0.7 (forests)
! 2025-11 Wen Meng Set the upper bound for GFS to 24.135 km
!
!------------------------------------------------------------------
!
Expand Down Expand Up @@ -387,6 +388,8 @@ SUBROUTINE CALVIS_GSD(CZEN,VIS)
if (vis(i,j)<1.) vis1km_cnt = vis1km_cnt + 1
if (vis(i,j)<3.) vis3km_cnt = vis3km_cnt + 1
if (vis(i,j)<5.) vis5km_cnt = vis5km_cnt + 1
! Modify upper bound for GFS
if (modelname=='GFS') VIS(I,J)=MIN(24.135,VIS(I,J))
! convert vis from km to [m]
vis(i,j) = vis(i,j) * 1000.

Expand Down
103 changes: 51 additions & 52 deletions tests/logs/rt.log.HERCULES_intel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,66 +1,65 @@
===== Start of UPP Regression Testing Log =====
UPP Hash Tested:
6453248f7973a717f18ec6e1f4da775626f1cc58
10a8c904d6bb70452b0fe904ce246d28aadc8051

Submodule hashes:
-179cae1dd84401cf25d250bd9102e66560a9d328 sorc/libIFI.fd
-3d35332fe66e3e63a285cc8d96facdf255a33481 sorc/ncep_post.fd/post_gtg.fd

Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1361_hercules_intel/ci/rundir/upp-HERCULES
Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1369_hercules_intel/ci/rundir/upp-HERCULES
Baseline directory: /work/noaa/epic/role-epic/hercules/UPP

Total runtime: 00h:13m:35s
Test Date: 20251120 10:33:01
Total runtime: 00h:14m:13s
Test Date: 20251121 08:10:55
Summary Results:

11/20 16:23:10Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
11/20 16:23:11Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
11/20 16:23:11Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
11/20 16:24:10Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
11/20 16:24:26Z -3drtma test: your new post executable did not generate bit-identical WRFTWO.GrbF00 as the develop branch
11/20 16:24:26Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
11/20 16:24:27Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
11/20 16:24:27Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
11/20 16:25:06Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
11/20 16:25:08Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
11/20 16:25:15Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
11/20 16:25:25Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
11/20 16:25:26Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
11/20 16:25:27Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
11/20 16:25:32Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
11/20 16:25:38Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
11/20 16:25:38Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
11/20 16:25:39Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
11/20 16:25:43Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
11/20 16:25:55Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
11/20 16:25:56Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
11/20 16:27:08Z -hrrr test: your new post executable did not generate bit-identical WRFTWO.GrbF10 as the develop branch
11/20 16:27:08Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
11/20 16:27:09Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
11/20 16:27:21Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
11/20 16:28:29Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
11/20 16:28:40Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
11/20 16:32:48Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the develop branch
11/20 16:32:50Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
11/20 16:32:50Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
11/20 16:25:14Z -Runtime: sfs_test 00:00:06 -- baseline 00:01:20
11/20 16:25:14Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
11/20 16:25:29Z -Runtime: gefsv12_test 00:00:15 -- baseline 00:01:00
11/20 16:25:44Z -Runtime: gefsv13_test 00:00:43 -- baseline 00:02:00
11/20 16:25:44Z -Runtime: nmmb_test 00:01:11 -- baseline 00:03:00
11/20 16:25:59Z -Runtime: rap_test 00:00:56 -- baseline 00:02:00
11/20 16:27:14Z -Runtime: hrrr_test 00:02:09 -- baseline 00:06:00
11/20 16:27:14Z -Runtime: hafs_test 00:00:32 -- baseline 00:01:00
11/20 16:27:14Z -Runtime: 3drtma_test 00:02:27 -- baseline 00:03:00
11/20 16:27:14Z -Runtime: mpas_test 00:01:12 -- baseline 00:02:30
11/20 16:27:14Z -Runtime: mpas_hfip_test 00:01:57 -- baseline 00:05:00
11/20 16:27:15Z -Runtime: gcafs_test 00:02:27 -- baseline 00:02:30
11/20 16:28:45Z -Runtime: rrfs_test 00:06:40 -- baseline 00:12:00
11/20 16:28:45Z -Runtime: rrfs_ifi_missing 00:02:21 -- baseline 00:04:00
11/20 16:33:00Z -Runtime: gfs_test 00:07:50 -- baseline 00:25:00
11/21 13:58:57Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
11/21 14:02:06Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
11/21 14:02:06Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
11/21 14:02:07Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
11/21 14:02:47Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
11/21 14:02:47Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
11/21 14:02:48Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
11/21 14:02:49Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
11/21 14:02:51Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
11/21 14:02:51Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
11/21 14:03:01Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
11/21 14:03:16Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
11/21 14:03:24Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
11/21 14:03:38Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
11/21 14:03:52Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
11/21 14:03:53Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
11/21 14:03:57Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
11/21 14:03:58Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
11/21 14:03:58Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
11/21 14:04:49Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
11/21 14:04:49Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
11/21 14:04:51Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
11/21 14:05:13Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
11/21 14:05:22Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
11/21 14:05:23Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
11/21 14:07:17Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
11/21 14:07:27Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
11/21 14:10:48Z -gfs test: your new post executable did not generate bit-identical gfs.t00z.master.grb2f006 as the develop branch
11/21 14:10:49Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
11/21 14:10:49Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
11/21 13:59:22Z -Runtime: sfs_test 00:00:05 -- baseline 00:01:20
11/21 14:03:08Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
11/21 14:03:23Z -Runtime: gefsv12_test 00:00:23 -- baseline 00:01:00
11/21 14:03:53Z -Runtime: gefsv13_test 00:00:46 -- baseline 00:02:00
11/21 14:04:08Z -Runtime: nmmb_test 00:01:05 -- baseline 00:03:00
11/21 14:04:08Z -Runtime: rap_test 00:01:00 -- baseline 00:02:00
11/21 14:04:53Z -Runtime: hrrr_test 00:01:58 -- baseline 00:06:00
11/21 14:04:53Z -Runtime: hafs_test 00:00:31 -- baseline 00:01:00
11/21 14:04:53Z -Runtime: 3drtma_test 00:01:55 -- baseline 00:03:00
11/21 14:04:53Z -Runtime: mpas_test 00:01:14 -- baseline 00:02:30
11/21 14:04:53Z -Runtime: mpas_hfip_test 00:01:58 -- baseline 00:05:00
11/21 14:05:24Z -Runtime: gcafs_test 00:02:30 -- baseline 00:02:30
11/21 14:07:39Z -Runtime: rrfs_test 00:06:34 -- baseline 00:12:00
11/21 14:07:39Z -Runtime: rrfs_ifi_missing 00:02:21 -- baseline 00:04:00
11/21 14:10:54Z -Runtime: gfs_test 00:09:56 -- baseline 00:25:00
Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
There are changes in results for case 3drtma in /work2/noaa/epic/clyden/regression-tests/upp/hercules/1361_hercules_intel/ci/rundir/upp-HERCULES/3drtma_2025091010/WRFTWO.GrbF00
There are changes in results for case hrrr in /work2/noaa/epic/clyden/regression-tests/upp/hercules/1361_hercules_intel/ci/rundir/upp-HERCULES/hrrr_2025063004/WRFTWO.GrbF10
Refer to .diff files in rundir: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1361_hercules_intel/ci/rundir/upp-HERCULES for details on differences in results for each case.
There are changes in results for case gfs in /work2/noaa/epic/clyden/regression-tests/upp/hercules/1369_hercules_intel/ci/rundir/upp-HERCULES/gfs_2025012600/gfs.t00z.master.grb2f006
Refer to .diff files in rundir: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1369_hercules_intel/ci/rundir/upp-HERCULES for details on differences in results for each case.
===== End of UPP Regression Testing Log =====
Loading