Update cloud to spack-stack 1.9.2 with GNU stack fix#82
Merged
CoryMartin-NOAA merged 19 commits intoAug 5, 2025
Conversation
9 tasks
Contributor
Author
|
Putting this PR into draft mode to include spack-stack 1.9.1 update. |
RussTreadon-NOAA
previously approved these changes
Jul 3, 2025
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
I did not test the changes in the PR but if the changes work for you (@TaylorRoper-NOAA), I'm fine with these changes.
Approve.
TaylorRoper-NOAA
changed the title
Contributor
Author
|
This PR is waiting for merging of #78 |
4 tasks
TaylorRoper-NOAA
changed the title
Contributor
Author
|
@DavidHuber-NOAA @RussTreadon-NOAA With the merging of #78, this PR is now ready for re-review. The only difference in cloud module files between when this PR was originally reviewed and now is updating the spack-stack version from 1.9.1 to 1.9.2. The build using 1.9.2 was successful with no errors and no new warnings. |
RussTreadon-NOAA
approved these changes
Aug 4, 2025
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
I can not test this change. @TaylorRoper-NOAA tested and found acceptable behavior.
Approve.
DavidHuber-NOAA
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unloading of
gnufrom the cloud module file. Loadinggnuadds GCC libraries and tools to the necessary paths that are needed in the stack. There are different GCC version defaults on the legacy versus latest NOAA RDHPCS cloud/appssnapshots (13.2.0 for legacy, 14.2.0 for latest), and these different version module files have different configurations so that the GCC version is specified as 13.2.0 to have consistency across the different/appsmounts.I cloned and ran the build script on PW AWS with latest
/appssnapshot mounted. I am not currently able to test with the legacy/appssnapshot, but the GCC default version is specified as 13.2.0 in this PR which is the default GCC version on the legacy/appssnapshot so that the build should finish successfully regardless of which/appssnapshot is mounted.Resolves #81