Update cloud to spack-stack 1.9.2 with GNU stack fix

[TaylorRoper-NOAA]

Description

This PR removes the unloading of gnu from the cloud module file. Loading gnu adds GCC libraries and tools to the necessary paths that are needed in the stack. There are different GCC version defaults on the legacy versus latest NOAA RDHPCS cloud /apps snapshots (13.2.0 for legacy, 14.2.0 for latest), and these different version module files have different configurations so that the GCC version is specified as 13.2.0 to have consistency across the different /apps mounts.

Resolves #901

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

I cloned and ran the build script on PW AWS with latest /apps snapshot mounted. I am not currently able to test with the legacy /apps snapshot, but the GCC default version is specified as 13.2.0 in this PR which is the default GCC version on the legacy /apps snapshot so that the build should finish successfully regardless of which /apps snapshot is mounted.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

[TaylorRoper-NOAA]

Putting this PR into draft mode to include spack-stack 1.9.1 update.

[TaylorRoper-NOAA]

This PR is waiting for #890 to merge.

[TaylorRoper-NOAA]

Marking this PR as ready for review. I've updated the cloud module files to use spack-stack 1.9.2 and tested the build after the merging of #890. The build is successful with no errors and one warning (deprecation):

/contrib/dev/GSI/src/gsi/stpjcmod.f90(920): warning #9111: The minus (-) operator for OpenMP* reduction clauses is deprecated.
!$omp parallel do private(k,j,i,ii) firstprivate(rcon,con) reduction(-:dmn) reduction(-:dmn2) collapse(2)

@DavidHuber-NOAA @weihuang-jedi This PR is now ready for review.

[DavidHuber-NOAA]

Looks good to me. Thanks Taylor!

[RussTreadon-NOAA]

This PR only modifies modulefiles/gsi_noaacloud.intel.lua. Thus, this PR does not impact the machines which most developers use: Gaea C6, Hera, Hercules, Orion, Ursa, and WCOSS2.

I do not have cloud access to test the changes to modulefiles/gsi_noaacloud.intel.lua.

Approve pending confirmation that the changes work as intended.

[RussTreadon-NOAA]

@weihuang-jedi : Do you have any input regarding this PR? We can schedule this PR for merger into GSI develop assuming you have no request for change or objections.

[TaylorRoper-NOAA]

This PR only modifies modulefiles/gsi_noaacloud.intel.lua. Thus, this PR does not impact the machines which most developers use: Gaea C6, Hera, Hercules, Orion, Ursa, and WCOSS2.

I do not have cloud access to test the changes to modulefiles/gsi_noaacloud.intel.lua.

Approve pending confirmation that the changes work as intended.

Thank you, @RussTreadon-NOAA, for taking a look at this PR and moving it forward. I can confirm that these changes allow a successful GSI build on the cloud using spack-stack 1.9.2; see build logs on Hera/Ursa here: /scratch3/BMC/qosap/Taylor.Roper/shared/build_gsi.log. I have not tested the run-time functionality of GSI since GSI is only partially ported to the cloud at this point.

[weihuang-jedi]

I have looked the code changes, which looks good to me.
I checked out the code with the code changes on AWS, and it compiles fine.