Skip to content

Upgrade to spack-stack 1.9.2#78

Merged
aerorahul merged 17 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:feature/spack-stack_191
Jul 17, 2025
Merged

Upgrade to spack-stack 1.9.2#78
aerorahul merged 17 commits into
NOAA-EMC:developfrom
DavidHuber-NOAA:feature/spack-stack_191

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA commented May 29, 2025

This upgrades GSI-utils to spack-stack 1.9.1 and updates the WCOSS2 modules (still a WIP).

Resolves #76
Resolves #77
Resolves #48
Partially addresses #21

Comment thread src/NMC_Bkerror/sorc/specgrid.f90
@DavidHuber-NOAA DavidHuber-NOAA changed the title Upgrade to spack-stack 1.9.1 Upgrade to spack-stack 1.9.2 Jul 3, 2025
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review July 3, 2025 16:50
@DavidHuber-NOAA
Copy link
Copy Markdown
Collaborator Author

This PR is now ready for review, noting the following:

  • There are no system tests for GSI-utils, so this can only be tested in the global workflow
    • So far, only Gaea C6 has been tested via a C96_3denvar ATM-only test case
    • Thus, marine testing has not been performed yet
  • Build tests are not currently possible. @AlexanderRichert-NOAA could you help with this?
    • This is because GSI-utils makes use of both the real4 and real8 ip modules, but in different executables.
    • Thus, both ip_4 and ip_d have to be installed
    • However, when spack installs into the GitHub runner, it does so in common include_4 and include_d spaces
    • When compiling, -I flags are passed to the compiler for both locations, meaning both the ip_4 and ip_8 modules are available for the compiler to choose from
    • For some executables, this means that the wrong ip module is being referenced, causing type mismatches

Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. As long as these work on OnPrem systems, I am ok ignoring the GA build failures -- for now

@aerorahul aerorahul merged commit 7b7fb72 into NOAA-EMC:develop Jul 17, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port to Ursa Upgrade to spack-stack 1.9.1 Upgrade to BUFR 12

3 participants