Skip to content

Add build script, bundle CMakeLists.txt and modify .gitignore files#3

Merged
CoryMartin-NOAA merged 2 commits into
developfrom
feature/build
Mar 21, 2022
Merged

Add build script, bundle CMakeLists.txt and modify .gitignore files#3
CoryMartin-NOAA merged 2 commits into
developfrom
feature/build

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Mar 18, 2022

This PR adds in from JEDI-T2O/UFS-DA modulefiles, scripts, and the bundle file for building the GDASApp with JEDI repositories. This will include all repos needed for both FV3-JEDI and SOCA.

NOTE: the modulefiles will need modified soon once there are python virtual environments set up with the correct R2D2 hashes.

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Mar 18, 2022
RussTreadon-NOAA
RussTreadon-NOAA reviewed Mar 18, 2022
View reviewed changes
Comment thread ush/build_GDASApp.sh
RussTreadon-NOAA
RussTreadon-NOAA reviewed Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. One just curious question.

RussTreadon-NOAA
RussTreadon-NOAA approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Mar 18, 2022

@guillaumevernieres I believe I have all the repos needed for SOCA but please confirm. The soca_hofx.x and soca_var.x (among others) built.

guillaumevernieres
guillaumevernieres reviewed Mar 18, 2022
View reviewed changes
Comment thread src/CMakeLists.txt
ecbuild_bundle( PROJECT fv3-jedi-lm GIT "https://github.com/jcsda/fv3-jedi-linearmodel.git" BRANCH develop UPDATE )
ecbuild_bundle( PROJECT fv3-jedi GIT "https://github.com/jcsda/fv3-jedi.git" BRANCH develop UPDATE )

# SOCA associated repositories
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soca is NOT an option! I like it :) but it might not be very practical for the short term. Something we can revisit in the near future.

@guillaumevernieres
Copy link
Copy Markdown
Contributor

guillaumevernieres commented Mar 18, 2022

@guillaumevernieres I believe I have all the repos needed for SOCA but please confirm. The soca_hofx.x and soca_var.x (among others) built.

@CoryMartin-NOAA Looks fine to me but testing a build to make sure I can replicate your work.

guillaumevernieres
guillaumevernieres approved these changes Mar 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @CoryMartin-NOAA . I didn't try to build on orion, but it's fine in the container.

@CoryMartin-NOAA CoryMartin-NOAA merged commit b885fa1 into develop Mar 21, 2022
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/build branch March 21, 2022 14:27
@aerorahul aerorahul mentioned this pull request Mar 21, 2022
Merged
This was referenced Sep 13, 2022
Closed
Merged
guillaumevernieres added a commit that referenced this pull request May 23, 2024
@guillaumevernieres
Optionally run specified rocoto task as part of the ctests (#1121)
af7fb73 
Only tested with the coupled UFS and the marine DA tasks:
```
Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci
  Test  #1: C48mx500_3DVarAOWCDA
  Test  #2: C96_atmaerosnowDA
  Test  #3: C96C48_ufs_hybatmDA
  Test  #4: C48mx500_3DVarAOWCDA_gdasfcst_202103241200
  Test  #5: C48mx500_3DVarAOWCDA_gdasprepoceanobs_202103241800
  Test  #6: C48mx500_3DVarAOWCDA_gdasocnanalprep_202103241800
  Test  #7: C48mx500_3DVarAOWCDA_gdasocnanalbmat_202103241800
  Test  #8: C48mx500_3DVarAOWCDA_gdasocnanalrun_202103241800
  Test  #9: C48mx500_3DVarAOWCDA_gdasocnanalchkpt_202103241800
  Test #10: C48mx500_3DVarAOWCDA_gdasocnanalpost_202103241800

Total Tests: 10
```
guillaumevernieres added a commit that referenced this pull request May 28, 2024
@guillaumevernieres @CoryMartin-NOAA
Addin a GFSv17 ctest (#1130)
4598d91 
**What was done:**
- reorganization/code tidy to facilitate the addition of a GFSv17
prototype ctest
- exclude the new ctest by default, the user will have to run ```cmake
-DRUNGWCI=ON .``` on an old build to configure the new ctest

He're the current list:

```
 Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci
  Test  #1: WCDA-3DVAR-C48mx500
  Test  #2: WCDA-3DVAR-C48mx500_gdasfcst_202103241200
  Test  #3: WCDA-3DVAR-C48mx500_gdasprepoceanobs_202103241800
  Test  #4: WCDA-3DVAR-C48mx500_gdasocnanalprep_202103241800
  Test  #5: WCDA-3DVAR-C48mx500_gdasocnanalbmat_202103241800
  Test  #6: WCDA-3DVAR-C48mx500_gdasocnanalrun_202103241800
  Test  #7: WCDA-3DVAR-C48mx500_gdasocnanalchkpt_202103241800
  Test  #8: WCDA-3DVAR-C48mx500_gdasocnanalpost_202103241800
  Test  #9: Aero-Snow-3DVAR-C96
  Test #10: Aero-Snow-3DVAR-C96_gdasfcst_202112201200
  Test #11: Atm-hyb-C96C48
  Test #12: Atm-hyb-C96C48_gdasfcst_202402231800
  Test #13: GFSv17-3DVAR-C384mx025
  Test #14: GFSv17-3DVAR-C384mx025_gdasfcst_202106300000
  Test #15: GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600
  Test #16: GFSv17-3DVAR-C384mx025_gdasocnanalprep_202106300600
  Test #17: GFSv17-3DVAR-C384mx025_gdasocnanalbmat_202106300600
  Test #18: GFSv17-3DVAR-C384mx025_gdasocnanalrun_202106300600
  Test #19: GFSv17-3DVAR-C384mx025_gdasocnanalchkpt_202106300600
  Test #20: GFSv17-3DVAR-C384mx025_gdasocnanalpost_202106300600
  Test #21: GFSv17-3DVAR-C384mx025_gdasocnanalvrfy_202106300600
  Test #22: GFSv17-3DVAR-C384mx025_gdasprep_202106300600
  Test #23: GFSv17-3DVAR-C384mx025_gdasanal_202106300600

Total Tests: 23
```

---------

Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
@jianjunj jianjunj mentioned this pull request Sep 4, 2025
Open
DavidNew-NOAA pushed a commit that referenced this pull request Jan 6, 2026
@danholdaway
Merge pull request #3 from NOAA-EMC/feature/atmensanlfv3inc
785af90 
Modify input YAML for FV3 increment converter (LETKF)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@CoryMartin-NOAA
Add build script, bundle CMakeLists.txt and modify .gitignore files (#3)
3d07194
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@guillaumevernieres
Optionally run specified rocoto task as part of the ctests (#1121)
e2312c2 
Only tested with the coupled UFS and the marine DA tasks:
```
Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci
  Test  #1: C48mx500_3DVarAOWCDA
  Test  #2: C96_atmaerosnowDA
  Test  #3: C96C48_ufs_hybatmDA
  Test  #4: C48mx500_3DVarAOWCDA_gdasfcst_202103241200
  Test  #5: C48mx500_3DVarAOWCDA_gdasprepoceanobs_202103241800
  Test  #6: C48mx500_3DVarAOWCDA_gdasocnanalprep_202103241800
  Test  #7: C48mx500_3DVarAOWCDA_gdasocnanalbmat_202103241800
  Test  #8: C48mx500_3DVarAOWCDA_gdasocnanalrun_202103241800
  Test  #9: C48mx500_3DVarAOWCDA_gdasocnanalchkpt_202103241800
  Test #10: C48mx500_3DVarAOWCDA_gdasocnanalpost_202103241800

Total Tests: 10
```
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@guillaumevernieres @CoryMartin-NOAA
Addin a GFSv17 ctest (#1130)
44a870c 
**What was done:**
- reorganization/code tidy to facilitate the addition of a GFSv17
prototype ctest
- exclude the new ctest by default, the user will have to run ```cmake
-DRUNGWCI=ON .``` on an old build to configure the new ctest

He're the current list:

```
 Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci
  Test  #1: WCDA-3DVAR-C48mx500
  Test  #2: WCDA-3DVAR-C48mx500_gdasfcst_202103241200
  Test  #3: WCDA-3DVAR-C48mx500_gdasprepoceanobs_202103241800
  Test  #4: WCDA-3DVAR-C48mx500_gdasocnanalprep_202103241800
  Test  #5: WCDA-3DVAR-C48mx500_gdasocnanalbmat_202103241800
  Test  #6: WCDA-3DVAR-C48mx500_gdasocnanalrun_202103241800
  Test  #7: WCDA-3DVAR-C48mx500_gdasocnanalchkpt_202103241800
  Test  #8: WCDA-3DVAR-C48mx500_gdasocnanalpost_202103241800
  Test  #9: Aero-Snow-3DVAR-C96
  Test #10: Aero-Snow-3DVAR-C96_gdasfcst_202112201200
  Test #11: Atm-hyb-C96C48
  Test #12: Atm-hyb-C96C48_gdasfcst_202402231800
  Test #13: GFSv17-3DVAR-C384mx025
  Test #14: GFSv17-3DVAR-C384mx025_gdasfcst_202106300000
  Test #15: GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600
  Test #16: GFSv17-3DVAR-C384mx025_gdasocnanalprep_202106300600
  Test #17: GFSv17-3DVAR-C384mx025_gdasocnanalbmat_202106300600
  Test #18: GFSv17-3DVAR-C384mx025_gdasocnanalrun_202106300600
  Test #19: GFSv17-3DVAR-C384mx025_gdasocnanalchkpt_202106300600
  Test #20: GFSv17-3DVAR-C384mx025_gdasocnanalpost_202106300600
  Test #21: GFSv17-3DVAR-C384mx025_gdasocnanalvrfy_202106300600
  Test #22: GFSv17-3DVAR-C384mx025_gdasprep_202106300600
  Test #23: GFSv17-3DVAR-C384mx025_gdasanal_202106300600

Total Tests: 23
```

---------

Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
RussTreadon-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@danholdaway
Merge pull request #3 from NOAA-EMC/feature/atmensanlfv3inc
567c629 
Modify input YAML for FV3 increment converter (LETKF)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CoryMartin-NOAA @guillaumevernieres @RussTreadon-NOAA