Set up beginning CI and add YAML check script by CoryMartin-NOAA · Pull Request #1 · NOAA-EMC/GDASApp

CoryMartin-NOAA · 2022-03-16T21:04:53Z

This PR adds:

pycodestyle CI test
unit test for YAML checker
YAML checker
basic cmake structure

guillaumevernieres

That was quick @CoryMartin-NOAA !
Looks good to me. Could the python norm check be added or moved to the list of ctests?

CoryMartin-NOAA · 2022-03-16T21:16:59Z

That was quick @CoryMartin-NOAA ! Looks good to me. Could the python norm check be added or moved to the list of ctests?

@guillaumevernieres of course! It's probably good to keep a separate norms test for quick edits, but we can add a ctest for the norms also

guillaumevernieres · 2022-03-16T21:19:17Z

That was quick @CoryMartin-NOAA ! Looks good to me. Could the python norm check be added or moved to the list of ctests?

@guillaumevernieres of course! It's probably good to keep a separate norms test for quick edits, but we can add a ctest for the norms also

It works on my desktop ... Going to approve, that norm check can be implemented later.

guillaumevernieres

👍 @CoryMartin-NOAA

aerorahul · 2022-03-16T21:27:08Z

@@ -0,0 +1,3 @@
+add_test(NAME test_check_yaml_keys
+         COMMAND ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/ush/check_yaml_keys.py ${CMAKE_SOURCE_DIR}/test/testinput/check_yaml_keys_ref.yaml ${CMAKE_SOURCE_DIR}/test/testinput/check_yaml_keys_test.yaml


Looks good. Though, I would suggest using ${PROJECT_SOURCE_DIR} instead. The use of which will become clear when GDASApp is included as a project inside another project.

Same for ${PROJECT_BINARY_DIR}

aerorahul

LGTM

guillaumevernieres

SLGTM!

Only tested with the coupled UFS and the marine DA tasks: ``` Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci Test #1: C48mx500_3DVarAOWCDA Test #2: C96_atmaerosnowDA Test #3: C96C48_ufs_hybatmDA Test #4: C48mx500_3DVarAOWCDA_gdasfcst_202103241200 Test #5: C48mx500_3DVarAOWCDA_gdasprepoceanobs_202103241800 Test #6: C48mx500_3DVarAOWCDA_gdasocnanalprep_202103241800 Test #7: C48mx500_3DVarAOWCDA_gdasocnanalbmat_202103241800 Test #8: C48mx500_3DVarAOWCDA_gdasocnanalrun_202103241800 Test #9: C48mx500_3DVarAOWCDA_gdasocnanalchkpt_202103241800 Test #10: C48mx500_3DVarAOWCDA_gdasocnanalpost_202103241800 Total Tests: 10 ```

**What was done:** - reorganization/code tidy to facilitate the addition of a GFSv17 prototype ctest - exclude the new ctest by default, the user will have to run ```cmake -DRUNGWCI=ON .``` on an old build to configure the new ctest He're the current list: ``` Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci Test #1: WCDA-3DVAR-C48mx500 Test #2: WCDA-3DVAR-C48mx500_gdasfcst_202103241200 Test #3: WCDA-3DVAR-C48mx500_gdasprepoceanobs_202103241800 Test #4: WCDA-3DVAR-C48mx500_gdasocnanalprep_202103241800 Test #5: WCDA-3DVAR-C48mx500_gdasocnanalbmat_202103241800 Test #6: WCDA-3DVAR-C48mx500_gdasocnanalrun_202103241800 Test #7: WCDA-3DVAR-C48mx500_gdasocnanalchkpt_202103241800 Test #8: WCDA-3DVAR-C48mx500_gdasocnanalpost_202103241800 Test #9: Aero-Snow-3DVAR-C96 Test #10: Aero-Snow-3DVAR-C96_gdasfcst_202112201200 Test #11: Atm-hyb-C96C48 Test #12: Atm-hyb-C96C48_gdasfcst_202402231800 Test #13: GFSv17-3DVAR-C384mx025 Test #14: GFSv17-3DVAR-C384mx025_gdasfcst_202106300000 Test #15: GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600 Test #16: GFSv17-3DVAR-C384mx025_gdasocnanalprep_202106300600 Test #17: GFSv17-3DVAR-C384mx025_gdasocnanalbmat_202106300600 Test #18: GFSv17-3DVAR-C384mx025_gdasocnanalrun_202106300600 Test #19: GFSv17-3DVAR-C384mx025_gdasocnanalchkpt_202106300600 Test #20: GFSv17-3DVAR-C384mx025_gdasocnanalpost_202106300600 Test #21: GFSv17-3DVAR-C384mx025_gdasocnanalvrfy_202106300600 Test #22: GFSv17-3DVAR-C384mx025_gdasprep_202106300600 Test #23: GFSv17-3DVAR-C384mx025_gdasanal_202106300600 Total Tests: 23 ``` --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>

Add some yaml files

Adds: pycodestyle CI test unit test for YAML checker YAML checker basic cmake structure

Only tested with the coupled UFS and the marine DA tasks: ``` Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci Test #1: C48mx500_3DVarAOWCDA Test #2: C96_atmaerosnowDA Test #3: C96C48_ufs_hybatmDA Test #4: C48mx500_3DVarAOWCDA_gdasfcst_202103241200 Test #5: C48mx500_3DVarAOWCDA_gdasprepoceanobs_202103241800 Test #6: C48mx500_3DVarAOWCDA_gdasocnanalprep_202103241800 Test #7: C48mx500_3DVarAOWCDA_gdasocnanalbmat_202103241800 Test #8: C48mx500_3DVarAOWCDA_gdasocnanalrun_202103241800 Test #9: C48mx500_3DVarAOWCDA_gdasocnanalchkpt_202103241800 Test #10: C48mx500_3DVarAOWCDA_gdasocnanalpost_202103241800 Total Tests: 10 ```

**What was done:** - reorganization/code tidy to facilitate the addition of a GFSv17 prototype ctest - exclude the new ctest by default, the user will have to run ```cmake -DRUNGWCI=ON .``` on an old build to configure the new ctest He're the current list: ``` Test project /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/runs/prs/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci Test #1: WCDA-3DVAR-C48mx500 Test #2: WCDA-3DVAR-C48mx500_gdasfcst_202103241200 Test #3: WCDA-3DVAR-C48mx500_gdasprepoceanobs_202103241800 Test #4: WCDA-3DVAR-C48mx500_gdasocnanalprep_202103241800 Test #5: WCDA-3DVAR-C48mx500_gdasocnanalbmat_202103241800 Test #6: WCDA-3DVAR-C48mx500_gdasocnanalrun_202103241800 Test #7: WCDA-3DVAR-C48mx500_gdasocnanalchkpt_202103241800 Test #8: WCDA-3DVAR-C48mx500_gdasocnanalpost_202103241800 Test #9: Aero-Snow-3DVAR-C96 Test #10: Aero-Snow-3DVAR-C96_gdasfcst_202112201200 Test #11: Atm-hyb-C96C48 Test #12: Atm-hyb-C96C48_gdasfcst_202402231800 Test #13: GFSv17-3DVAR-C384mx025 Test #14: GFSv17-3DVAR-C384mx025_gdasfcst_202106300000 Test #15: GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600 Test #16: GFSv17-3DVAR-C384mx025_gdasocnanalprep_202106300600 Test #17: GFSv17-3DVAR-C384mx025_gdasocnanalbmat_202106300600 Test #18: GFSv17-3DVAR-C384mx025_gdasocnanalrun_202106300600 Test #19: GFSv17-3DVAR-C384mx025_gdasocnanalchkpt_202106300600 Test #20: GFSv17-3DVAR-C384mx025_gdasocnanalpost_202106300600 Test #21: GFSv17-3DVAR-C384mx025_gdasocnanalvrfy_202106300600 Test #22: GFSv17-3DVAR-C384mx025_gdasprep_202106300600 Test #23: GFSv17-3DVAR-C384mx025_gdasanal_202106300600 Total Tests: 23 ``` --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>

Add some yaml files

CoryMartin-NOAA added 3 commits March 16, 2022 16:42

Start of attempt for CMake and python norms test

03975e0

Fix coding norms

f1353bc

Working first unit test

bf7bd39

CoryMartin-NOAA requested review from RussTreadon-NOAA, aerorahul and guillaumevernieres March 16, 2022 21:04

guillaumevernieres reviewed Mar 16, 2022

View reviewed changes

guillaumevernieres previously approved these changes Mar 16, 2022

View reviewed changes

aerorahul reviewed Mar 16, 2022

View reviewed changes

ensure GDASApp everywhere

22eb825

CoryMartin-NOAA dismissed guillaumevernieres’s stale review via 22eb825 March 16, 2022 21:31

CMAKE to PROJECT

815310b

aerorahul approved these changes Mar 16, 2022

View reviewed changes

CoryMartin-NOAA requested a review from guillaumevernieres March 16, 2022 21:36

guillaumevernieres approved these changes Mar 16, 2022

View reviewed changes

CoryMartin-NOAA merged commit d561e30 into develop Mar 17, 2022

CoryMartin-NOAA deleted the feature/first_ctest branch March 17, 2022 12:39

hyunchul386 mentioned this pull request Sep 13, 2022

Prepare JEDI increment so it can be used by MOM6 iau #121

Closed

3 tasks

DavidNew-NOAA pushed a commit that referenced this pull request Jan 6, 2026

Merge pull request #1 from NOAA-EMC/feature/work

a89be1a

Add some yaml files

DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026

Set up beginning CI and add YAML check script (#1)

8d8532c

Adds: pycodestyle CI test unit test for YAML checker YAML checker basic cmake structure

RussTreadon-NOAA pushed a commit that referenced this pull request Jan 16, 2026

Merge pull request #1 from NOAA-EMC/feature/work

e2b5f94

Add some yaml files

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up beginning CI and add YAML check script#1

Set up beginning CI and add YAML check script#1
CoryMartin-NOAA merged 5 commits into
developfrom
feature/first_ctest

CoryMartin-NOAA commented Mar 16, 2022

Uh oh!

guillaumevernieres left a comment

Uh oh!

CoryMartin-NOAA commented Mar 16, 2022

Uh oh!

guillaumevernieres commented Mar 16, 2022

Uh oh!

guillaumevernieres left a comment

Uh oh!

aerorahul Mar 16, 2022 •

edited

Loading

Uh oh!

aerorahul left a comment

Uh oh!

guillaumevernieres left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,3 @@
		add_test(NAME test_check_yaml_keys
		COMMAND ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/ush/check_yaml_keys.py ${CMAKE_SOURCE_DIR}/test/testinput/check_yaml_keys_ref.yaml ${CMAKE_SOURCE_DIR}/test/testinput/check_yaml_keys_test.yaml

Conversation

CoryMartin-NOAA commented Mar 16, 2022

Uh oh!

guillaumevernieres left a comment

Choose a reason for hiding this comment

Uh oh!

CoryMartin-NOAA commented Mar 16, 2022

Uh oh!

guillaumevernieres commented Mar 16, 2022

Uh oh!

guillaumevernieres left a comment

Choose a reason for hiding this comment

Uh oh!

aerorahul Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

guillaumevernieres left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aerorahul Mar 16, 2022 •

edited

Loading