add incr-update with IAU by hyunchul386 · Pull Request #129 · NOAA-EMC/GDASApp

hyunchul386 · 2022-09-13T20:33:38Z

##Description:

This PR is to add the increment of soca/jedi to MOM6 in GDASapp with ocean IAU, the same as one of soca-science.
The ctest of soca checks the generated updated increment file (inc.nc).

##Issue addressed:

This PR is to address the issue Prepare JEDI increment so it can be used by MOM6 iau #121 (Prepare JEDI increment so it can be used by MOM6 iau #121)

Testing:

Passing ctest (Add build script, bundle CMakeLists.txt and modify .gitignore files #3) of soca

##Dependency:

guillaumevernieres · 2022-09-13T21:56:51Z

 export R2D2_OBS_WINDOW=24     # R2D2 sampling DB window

-export APRUN_SOCAANAL="$MPIEXEC_EXEC $MPIEXEC_NPROC 6"
+export APRUN_SOCAANAL="$MPIEXEC_EXEC $MPIEXEC_NPROC 2"


back to 6 pe's please

guillaumevernieres · 2022-09-13T21:57:46Z


-export APRUN_SOCAANAL="$MPIEXEC_EXEC $MPIEXEC_NPROC 6"
+export APRUN_SOCAANAL="$MPIEXEC_EXEC $MPIEXEC_NPROC 2"
+#export APRUN_SOCAANAL="$MPIEXEC_EXEC $MPIEXEC_NPROC 12 --pty --preserve-env bash"


remove commented out line and what's below.

guillaumevernieres · 2022-09-14T14:58:40Z

+
+  echo "at socaincr2mom6" $bkg $grid
+
+  cp $incr inc.nc                   # TODO: use accumulated incremnet, not outerloop intermediates


remove comment once you point to the total increment.

doesn't look like it, I still see # TODO: use accumulated incremnet, not outerloop intermediates ... which presumably was done

guillaumevernieres · 2022-09-14T15:56:46Z


+
+# increment update for MOM6 iau
+# Make sure the last (most recent) increment file put into socaincr2mom6 as $1


I don't know what this comment means ...

hyunchul386 · 2022-09-14T16:00:07Z

The increment file is pointed to the file of ocn.3dvarfgat_pseudo.incr.*.nc.
In my check, the difference of T/S increments between the previous and the new ones are less than 10**-15, which would be expected.
One thing is that the new one also includes u/v (ssh and layer are still replaced to bckgroud anyway), so the output file size increases from 1.6M to 2.5M, because of adding u/v.

emcbot · 2022-09-15T14:13:52Z

Automated Pull Request Testing Results:
Machine: orion

Start: Thu Sep 15 08:30:18 CDT 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Sep 15 09:12:47 CDT 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Sep 15 09:13:51 CDT 2022
Tests: 86% tests passed, 2 tests failed out of 14
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/PR/129/GDASApp/build/log.ctest

emcbot · 2022-09-15T14:13:56Z

Automated Pull Request Testing Results:
Machine: hera

Start: Thu Sep 15 13:30:18 UTC 2022 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Sep 15 14:13:34 UTC 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Sep 15 14:13:56 UTC 2022
Tests: 86% tests passed, 2 tests failed out of 14
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/PR/129/GDASApp/build/log.ctest

* add incr-update with IAU * update PR#129 * pointing total increments * pointing full increments with cleaning * cleaning comments

add incr-update with IAU

01f5aea

hyunchul386 requested a review from guillaumevernieres September 13, 2022 20:34

guillaumevernieres reviewed Sep 13, 2022

View reviewed changes

Comment thread scripts/exgdas_global_marine_analysis_run.sh Outdated

guillaumevernieres reviewed Sep 13, 2022

View reviewed changes

Comment thread scripts/exgdas_global_marine_analysis_run.sh Outdated

guillaumevernieres reviewed Sep 13, 2022

View reviewed changes

update PR#129

b840cff

hyunchul386 requested a review from guillaumevernieres September 14, 2022 14:16

guillaumevernieres reviewed Sep 14, 2022

View reviewed changes

Comment thread scripts/exgdas_global_marine_analysis_run.sh Outdated

guillaumevernieres reviewed Sep 14, 2022

View reviewed changes

pointing total increments

9b0c307

hyunchul386 requested a review from guillaumevernieres September 14, 2022 15:35

pointing full increments with cleaning

b7ffd54

guillaumevernieres reviewed Sep 14, 2022

View reviewed changes

cleaning comments

0d9891a

hyunchul386 requested a review from guillaumevernieres September 14, 2022 16:04

guillaumevernieres reviewed Sep 14, 2022

View reviewed changes

Comment thread scripts/exgdas_global_marine_analysis_run.sh

hyunchul386 requested a review from guillaumevernieres September 14, 2022 17:48

guillaumevernieres added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Sep 15, 2022

emcbot added orion-RT-Running Automated testing running on Orion hera-RT-Running Automated testing running on Hera and removed orion-RT Queue for automated testing on Orion hera-RT Queue for automated testing on Hera labels Sep 15, 2022

emcbot added orion-RT-Failed Automated testing failed on Orion and removed orion-RT-Running Automated testing running on Orion labels Sep 15, 2022

emcbot removed the hera-RT-Running Automated testing running on Hera label Sep 15, 2022

emcbot added the hera-RT-Failed Automated testing failed on Hera label Sep 15, 2022

hyunchul386 added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion and removed orion-RT-Failed Automated testing failed on Orion hera-RT-Failed Automated testing failed on Hera labels Sep 15, 2022

emcbot added hera-RT-Running Automated testing running on Hera orion-RT-Running Automated testing running on Orion and removed hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Sep 15, 2022

guillaumevernieres approved these changes Sep 20, 2022

View reviewed changes

guillaumevernieres merged commit 8e8d725 into develop Sep 20, 2022

CoryMartin-NOAA deleted the feature/incr-update branch August 10, 2023 18:29

DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026

add incr-update with IAU (#129)

8b1edc7

* add incr-update with IAU * update PR#129 * pointing total increments * pointing full increments with cleaning * cleaning comments


		echo "at socaincr2mom6" $bkg $grid

		cp $incr inc.nc # TODO: use accumulated incremnet, not outerloop intermediates



		# increment update for MOM6 iau
		# Make sure the last (most recent) increment file put into socaincr2mom6 as $1

Conversation

hyunchul386 commented Sep 13, 2022

Testing:

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hyunchul386 commented Sep 14, 2022

Uh oh!

Uh oh!

emcbot commented Sep 15, 2022

Uh oh!

emcbot commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants