Update JEDI hashes and land-imsproc repo and hash#1775
Merged
Conversation
Contributor
Author
|
Attention: @ClaraDraper-NOAA , @yuanxue2870 , @YoulongXia-NOAA, and @CoryMartin-NOAA
The 20260628 stable-nightly run updated the Do we need to update the test data used by I'll poke around and see what I can figure out but you probably know exactly what needs to be fixed on our side so that We can not update the JEDI hashes in GDASApp until this problem is resolved (or we turn off the failing test ... not the recommended solution). |
Contributor
Hi Russ, Thanks for the info. You are correct that this failed test is related to an update in the ioda-converter yesterday. I will submit a PR to GDASApp next week with new testcase input and output files for this failed test case. Thanks! |
Contributor
Author
|
It looks like we need to pull changes from NOAA-EMC/land-SCF_proc PR #1 into GDASApp. Currently GDASApp Do we need to update GDASApp to point I did so as a test in a working copy of GDASApp Is it OK to update the GDASApp |
Contributor
Yes, exactly. The update in ioda-converter is built upon NOAA-EMC/land-SCF_proc@19957e5. Thanks for finding the solution quickly! |
Contributor
Author
|
Thank you @yuanxue2870 for your replies and confirmation of an acceptable path forward. |
RussTreadon-NOAA
changed the title
RussTreadon-NOAA
changed the title
RussTreadon-NOAA
added
hera-GW-RT
Contributor
Author
|
GDASApp CI Did not include
|
emcbot
added
hercules-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Passed
Contributor
Author
|
Hera 20250630 stable-nightly run Run GDASApp ctests with following results: All tests, including GCAFS, run to completion. |
Contributor
Author
|
This PR is ready for review |
RussTreadon-NOAA
requested review from
CoryMartin-NOAA,
DavidNew-NOAA and
yuanxue2870
CoryMartin-NOAA
approved these changes
Jun 30, 2025
Contributor
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Thank you, @RussTreadon-NOAA, for updating the hashes, particularly the IMS snow changes
DavidNew-NOAA
approved these changes
Jun 30, 2025
yuanxue2870
approved these changes
Jun 30, 2025
Contributor
yuanxue2870
left a comment
yuanxue2870
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you, Russ!
Contributor
Author
|
Thank you @CoryMartin-NOAA for merging! |
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
# Description Weekly update of JEDI hashes. Included in this week's update is an update to `sorc/land-imsproc`. The update to `sorc/land-imsproc` is twofold 1. change source repository from https://github.com/NOAA-PSL/land-IMS_proc.git to https://github.com/NOAA-EMC/land-SCF_proc.git via a change to `.gitmodules` 2. point at [land-imsproc @ 19957e5](https://github.com/NOAA-EMC/land-SCF_proc/tree/19957e5160f4793076d81549ffe88c17e1377583) # Companion PRs none # Issues none # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [x] atm_jjob <!-- JEDI atm single cycle DA !--> - [x] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [x] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [x] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Weekly update of JEDI hashes.
Included in this week's update is an update to
sorc/land-imsproc. The update tosorc/land-imsprocis twofold.gitmodulesCompanion PRs
none
Issues
none
Automated CI tests to run in Global Workflow