Update GDASApp to spack-stack/1.9.2#1684
Conversation
|
20250513 update This PR has, at present, one blocker. CRTM generates a segmentation fault when built with |
|
Automated GW-GDASApp Testing Results: |
|
@RussTreadon-NOAA I am at the point of being able to test this branch in NOAA-EMC/global-workflow#3798 on C6. Do you know if there are any changes required to the workflow to make this branch work (outside of module updates)? |
|
@DavidHuber-NOAA , Hera tests passed without any changes to g-w. Hopefully this holds true on Gaea C6. Caveat: I have not extensively tested GDASApp on Gaea C6. This PR may not work on the first Gaea C6 g-w attempt. |
|
Hera ctests Install
@CoryMartin-NOAA and @andytangborn : When we update GDASApp to spack-stack/1.9.2 we need to modify g-w Reran |
|
Orion and Hercules ctests Install The Hercules results are the same apart from the tests taking longer to run due to longer queue wait times The Notice that on MSU machines Logic found in lines 58 to 76 in The missing tests would be included on MSU machines if and the above tests are not included in the build. In contrast, the Hera GDASApp build log contains the message |
|
Ursa ctests Install feature/spack-stack191 at f4cbf57 inside g-w with the following results All tests run on Ursa Passed. |
|
Gaea C6 ctests Install feature/spack-stack191 at f4cbf57 inside g-w with the following results Rerunning the failed tests with |
|
The changes in the PR have been tested on Hera, Orion, and Hercules, GDASApp ctest behavior is as expected. A subset of test were run on Ursa and Gaea C6. The Ursa results are reasonable. There are two unexpected failures on Gaea C6. These failures may pre-date the update to spack-stack/1.9.2`. The branch for the PR remains |
|
The changes in the PR are ready for review. |
|
No tests were run on Dogwood because this PR does not modify the WCOSS2 build or how GDASApp runs on WCOSS2. |
|
Gaea C6 ctests - debug build Rebuild GDASApp with The two tests which previously failed, now pass. Recompiling with Debug RelWithDebInfo The only evident differnce is level 0 -vs- level 2 optimization. The
Line 568 is the Via prints find that there is an |
|
Thank you @DavidNew-NOAA for the review and approval. Merging now. |
Description
This PR updates the GDASApp build to
spack-stack/1.9.2Companion PRs
none
Issues
Resolves #1283
Automated CI tests to run in Global Workflow