This repository was archived by the owner on May 5, 2026. It is now read-only.
Add station IDs with txxxxyyyy for processed IMS snow DA#1
Merged
Merged
Conversation
CoryMartin-NOAA
requested review from
CoryMartin-NOAA,
jiaruidong2017,
tsga and
yuanxue2870
Comment on lines
+175
to
+187
| if(i<=9) then | ||
| write(istr1,'(i1)') i | ||
| xind='000'//istr1 | ||
| else if (i >= 10 .AND. i <= 99) then | ||
| write(istr2,'(i2)') i | ||
| xind='00'//istr2 | ||
| else if (i >= 100 .AND. i <= 999) then | ||
| write(istr3,'(i3)') i | ||
| xind='0'//istr3 | ||
| else | ||
| write(istr4,'(i4)') i | ||
| xind=istr4 | ||
| end if |
There was a problem hiding this comment.
can't you specify leading zeros in the write statement format?
Author
There was a problem hiding this comment.
Corrected as suggested. I test both nc and ascii input. Thank you for simplifying the code.
| character(len=3) :: jstr3,istr3 | ||
| character(len=4) :: xind, yind, jstr4,istr4 | ||
| character(len=9) :: staids(idim,jdim,6) ! station ID string | ||
| integer :: sid(idim,jdim,6) ! staiion ID integer |
There was a problem hiding this comment.
Suggested change
| integer :: sid(idim,jdim,6) ! staiion ID integer | |
| integer :: sid(idim,jdim,6) ! station ID integer |
| character(len=2) :: jstr2,istr2 | ||
| character(len=3) :: jstr3,istr3 | ||
| character(len=4) :: xind, yind, jstr4,istr4 | ||
| character(len=9) :: staids(idim,jdim,6) ! station ID string |
There was a problem hiding this comment.
Suggest to use standard name stid to replace staids
Comment on lines
+173
to
+177
| write(istr4,'(i4.4)') i | ||
| xind=istr4 | ||
| ! create yindex string for final station identification | ||
| write(jstr4,'(i4.4)') j | ||
| yind=jstr4 |
There was a problem hiding this comment.
Suggested change
| write(istr4,'(i4.4)') i | |
| xind=istr4 | |
| ! create yindex string for final station identification | |
| write(jstr4,'(i4.4)') j | |
| yind=jstr4 | |
| write(istr4,'(i4.4)') i | |
| xind=istr4 | |
| ! create yindex string for final station identification | |
| write(jstr4,'(i4.4)') j | |
| yind=jstr4 |
| do i=1,idim | ||
| do j=1,jdim | ||
| write(tile_str, '(i1)') t ! assuming <10 tiles. | ||
| ! create xindex string for final station identification |
There was a problem hiding this comment.
Suggested change
| ! create xindex string for final station identification | |
| ! create xindex string for final station identification |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Instructions:
Notes on preparing PR, using git can be found in README_git
Describe your changes
Summarise all code changes included in PR:
List any associated PRs in the submodules.
Issue ticket number and link
List the git Issue that this PR addresses:
Test output
Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Does it pass the DA_IMS_test?
If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
Checklist before requesting a review