Skip to content

Generalize job submission for select ctests#1771

Merged
RussTreadon-NOAA merged 35 commits into
developfrom
feature/ctests
Jul 24, 2025
Merged

Generalize job submission for select ctests#1771
RussTreadon-NOAA merged 35 commits into
developfrom
feature/ctests

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jun 26, 2025

Description

This PR relaxes the slurm scheduler assumption made for multiple GDASApp ctests. Machine specific yamls specify schedule, queues, and accounting codes for select machines. A python script generates a machine specific job card which the ctest submits.

Companion PRs

None

Issues

Resolves #1762

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 26, 2025
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Jul 16, 2025
7 tasks
@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Jul 23, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 23, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Jul 24, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Wed Jul 23 22:52:04 UTC 2025 on hfe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul 23 23:26:54 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jul 24 00:16:21 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 156

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 24, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Jul 24, 2025

Automated GW-GDASApp Testing Results:
Machine: orion

Start: Wed Jul 23 05:52:54 PM CDT 2025 on orion-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul 23 06:47:23 PM CDT 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E C96_gcafs_cycled
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jul 23 08:09:53 PM CDT 2025
Tests: 100% tests passed, 0 tests failed out of 132

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jul 24, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Jul 24, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Wed Jul 23 17:52:18 CDT 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul 23 18:26:01 CDT 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E C96_gcafs_cycled
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jul 23 20:42:02 CDT 2025
Tests: 100% tests passed, 0 tests failed out of 132

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Jul 24, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

GDASApp ctests, including select g-w CI tests, Pass on WCOSS2 (Cactus), Gaea C6, Hera, Hercules, and Orion. This PR is ready for review.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review July 24, 2025 10:07
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @RussTreadon-NOAA

Copy link
Copy Markdown
Collaborator

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the changes in the snow related tests. Thank @RussTreadon-NOAA for your great efforts.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @CoryMartin-NOAA , @jiaruidong2017 , and @DavidNew-NOAA for your quick reviews and approvals. Merging now.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 852904c into develop Jul 24, 2025
23 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/ctests branch July 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hera-GW-RT-Passed Automated testing with global-workflow successful on Hera hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules orion-GW-RT-Passed Automated testing with global-workflow successful on Orion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDASApp ctests review & refactor

5 participants