Skip to content

Get test data from a staged location on supported HPC Part Deux#1052

Merged
guillaumevernieres merged 3 commits into
developfrom
bugfix/test-data-2
Apr 16, 2024
Merged

Get test data from a staged location on supported HPC Part Deux#1052
guillaumevernieres merged 3 commits into
developfrom
bugfix/test-data-2

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Apr 16, 2024

Actually fixes #1046. No idea what went wrong on the previous PR.

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Apr 16, 2024
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 16, 2024
@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Apr 16, 2024

Cherry picked and new branch.

RussTreadon-NOAA
RussTreadon-NOAA approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @CoryMartin-NOAA for the quick fix!

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 16, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 16, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Apr 16 21:22:59 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Apr 16 22:11:01 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Apr 16 22:30:05 UTC 2024
Tests: 91% tests passed, 5 tests failed out of 54
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1776 - test_gdasapp_atm_jjob_var_run (Failed)
	1777 - test_gdasapp_atm_jjob_var_inc (Failed)
	1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1052/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 16, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 16, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Apr 16 16:21:33 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Apr 16 17:15:28 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Apr 16 17:37:47 CDT 2024
Tests: 93% tests passed, 4 tests failed out of 54
	1777 - test_gdasapp_atm_jjob_var_run (Failed)
	1778 - test_gdasapp_atm_jjob_var_inc (Failed)
	1779 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1052/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 16, 2024
guillaumevernieres
guillaumevernieres approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
🌮 's for @CoryMartin-NOAA

@guillaumevernieres guillaumevernieres merged commit 52c0d2d into develop Apr 16, 2024
@guillaumevernieres guillaumevernieres deleted the bugfix/test-data-2 branch April 16, 2024 23:00
danholdaway added a commit that referenced this pull request Apr 17, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
76c7851 
* upstream/develop:
  Get SOCA vrfy job working on Hera again (#1045)
  Get test data from a staged location on supported HPC Part Deux (#1052)
  Prepare observations for snow DA updates to the ensemble members (#998)
  Save basic stats in csv at each cycle (#1040)
  Fix bug for datetime in GHRSST Ioda Converter (#1027)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@CoryMartin-NOAA
Get test data from a staged location on supported HPC Part Deux (#1052)
ec79153 
Actually fixes #1046. No idea what went wrong on the previous PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GDASApp develop build problem

4 participants

@CoryMartin-NOAA @emcbot @guillaumevernieres @RussTreadon-NOAA