Skip to content

Fix bug for datetime in GHRSST Ioda Converter#1027

Merged
guillaumevernieres merged 10 commits into
developfrom
bugfix/ghrsst_datetime_cycle
Apr 15, 2024
Merged

Fix bug for datetime in GHRSST Ioda Converter#1027
guillaumevernieres merged 10 commits into
developfrom
bugfix/ghrsst_datetime_cycle

Conversation

@apchoiCMD
Copy link
Copy Markdown
Collaborator

@apchoiCMD apchoiCMD commented Apr 5, 2024 •
edited
Loading

@apchoiCMD apchoiCMD marked this pull request as draft April 5, 2024 18:38
@apchoiCMD apchoiCMD marked this pull request as ready for review April 5, 2024 18:51
guillaumevernieres
guillaumevernieres reviewed Apr 5, 2024
View reviewed changes
Comment thread utils/obsproc/Ghrsst2Ioda.h
@apchoiCMD apchoiCMD closed this Apr 11, 2024
@guillaumevernieres
Copy link
Copy Markdown
Contributor

guillaumevernieres commented Apr 11, 2024

I assume this was closed by mistake @apchoiCMD ?

@apchoiCMD
Copy link
Copy Markdown
Collaborator Author

apchoiCMD commented Apr 11, 2024

I assume this was closed by mistake @apchoiCMD ?

Oh, thanks- I don't even know it is closed.

guillaumevernieres
guillaumevernieres reviewed Apr 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you fixed the core of the issue, thanks @apchoiCMD ! But is the superobing still OK?

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 17:17:19 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Apr 12 17:17:39 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 12, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 22:34:26 UTC 2024 on hfe07
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 22:34:36 UTC 2024
Tests: 81% tests passed, 10 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1775 - test_gdasapp_atm_jjob_var_init (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 12, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 22:34:26 UTC 2024 on hfe07
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 22:34:36 UTC 2024
Tests: 81% tests passed, 10 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1775 - test_gdasapp_atm_jjob_var_init (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS
Build: Completed at Fri Apr 12 23:23:08 UTC 2024

Tests: Failed
Tests: Failed at Fri Apr 12 23:47:36 UTC 2024
Tests: 91% tests passed, 5 tests failed out of 53
1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
1776 - test_gdasapp_atm_jjob_var_run (Failed)
1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot
Copy link
Copy Markdown

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 17:17:19 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Apr 12 17:17:39 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/log.build

Build: SUCCESS
Build: Completed at Fri Apr 12 18:10:14 CDT 2024

Tests: Failed
Tests: Failed at Fri Apr 12 18:52:01 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
1777 - test_gdasapp_atm_jjob_var_run (Failed)
1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

guillaumevernieres
guillaumevernieres approved these changes Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @apchoiCMD . I'm going to merge this, along with the last analysis that you shared, the stats from @KatherineLukens-NOAA 's runs seems to indicate that what you did is correct.

@guillaumevernieres guillaumevernieres merged commit 6f7bd18 into develop Apr 15, 2024
@guillaumevernieres guillaumevernieres deleted the bugfix/ghrsst_datetime_cycle branch April 15, 2024 21:28
danholdaway added a commit that referenced this pull request Apr 17, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
76c7851 
* upstream/develop:
  Get SOCA vrfy job working on Hera again (#1045)
  Get test data from a staged location on supported HPC Part Deux (#1052)
  Prepare observations for snow DA updates to the ensemble members (#998)
  Save basic stats in csv at each cycle (#1040)
  Fix bug for datetime in GHRSST Ioda Converter (#1027)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@apchoiCMD @guillaumevernieres
Fix bug for datetime in GHRSST Ioda Converter (#1027)
5932c0a 
- Resolve the FillValue issue within obs/metadata calculation loop
- Fix the encountering a precision issue when converting the integer
values for datetime issue previously occurred
- Fixes #1019

---------

Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@KatherineLukens-NOAA KatherineLukens-NOAA Awaiting requested review from KatherineLukens-NOAA

Assignees

No one assigned

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GHRSST converter is not working properly

4 participants

@apchoiCMD @guillaumevernieres @emcbot @AndrewEichmann-NOAA