Fix test output for fv3jedi_fv3inc.h#1039
Merged
Merged
Conversation
CoryMartin-NOAA
approved these changes
Apr 12, 2024
CoryMartin-NOAA
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Failed
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Failed
Collaborator
Author
|
@CoryMartin-NOAA I was not expecting this test to pass on Orion, but fail on Hera. Something about "double free or corruption (!prev)" I will have to take a look on Monday. |
danholdaway
added a commit
that referenced
this pull request
Apr 15, 2024
* upstream/develop: remove seviri from gdas_prototype_3d yaml (#1043) Fix GW jjob tests for upcoming GW PR #2420 (#1041) Fix test output for fv3jedi_fv3inc.h (#1039) Run g-w linker script before ctest for prepoceanobs task (#1034) Update femps and fv3-jedi-lm (#1036) Add ability for JEDI-to-FV3 increment converter to process ensembles (#1022) Add AVHRR/NOAA-15/18/19 assimilation to end-to-end GDASApp validation (#997) Catch error when trying to copy missing obs files from DATA to ROTDIR in prepoceanobs (#1028)
DavidNew-NOAA
added a commit
that referenced
this pull request
Jan 16, 2026
I foolishly moved the test output print statements in fv3jedi_fv3inc.h around for aesthetic reasons AFTER I had ran test_gdasapp_fv3jedi_fv3inc to confirm that it still passed. It broke the test but I moved the print statements back to where they belong. The test now passes. --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I foolishly moved the test output print statements in fv3jedi_fv3inc.h around for aesthetic reasons AFTER I had ran test_gdasapp_fv3jedi_fv3inc to confirm that it still passed. It broke the test but I moved the print statements back to where they belong.
The test now passes.