Remove unused cmake macros

[climbfuji]

Heavy-axe cleanup: remove everything that isn't used right now.

Testing ongoing with NCEPLIBS-external, develop branch. Also need to test with the various NCEPLIBS.

[climbfuji]

@aerorahul @DusanJovic-NOAA @kgerheiser @mark-a-potts I simply removed everything except the NetCDF, ESMF and WGRIB2 find macros. If you think or already know that some of the stuff I deleted is required, please let me know.

[aerorahul]

@aerorahul @DusanJovic-NOAA @kgerheiser @mark-a-potts I simply removed everything except the NetCDF, ESMF and WGRIB2 find macros. If you think or already know that some of the stuff I deleted is required, please let me know.

dang!
Hopefully @kgerheiser will implement a cmake for wgrib2 and we can get rid of FindWGRIB2.cmake as well.

[climbfuji]

@aerorahul this works for me in NCEPLIBS-external (see PR NOAA-EMC/NCEPLIBS-external#57). Can you or somebody else please test that this trimmed down version still works with the NCEPLIBS-xyz that use CMakeModules (and with any other model that might use CMakeModules that I am not aware of)?

[aerorahul]

@climbfuji
I can test with NCEPLIBS and UFS-utils.
I don't know of any other application using CMakeModules.

[climbfuji]

That would be great, thanks. I noticed that a few of the NCEPLIBS-xyz are still using (or at least having) CMakeModules in .gitmodules.

…

On Jul 29, 2020, at 1:47 PM, Rahul Mahajan ***@***.***> wrote: @climbfuji <https://github.com/climbfuji> I can test with NCEPLIBS and UFS-utils. I don't know of any other application using CMakeModules. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RK4XMLLTSBJXYEHLFDR6B4FHANCNFSM4PK5AVDA>.

[kgerheiser]

wgrib2 is in NCEPLIBS now, along with its CMake build and package config.

[climbfuji]

wgrib2 is in NCEPLIBS now, along with its CMake build and package config.

Does this mean I should remove the FindWGRIB2.cmake from the repository as well?

[kgerheiser]

I'm not sure. It was just merged today and hasn't been installed anywhere yet and there may be some other applications (UFS_UTILS, maybe Post?) that need to be converted as well. Not that any of that is difficult, but it's not ready at this exact moment.

[climbfuji]

Thanks, I'll leave it as-is for now.

…

On Jul 29, 2020, at 1:54 PM, Kyle Gerheiser ***@***.***> wrote: I'm not sure. It was just merged today and hasn't been installed anywhere yet and there may be some other applications (UFS_UTILS, maybe Post?) that need to be converted as well. Not that any of that is difficult, but it's not ready at this exact moment. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2ROR5M7HT3E2W5IFQH3R6B47NANCNFSM4PK5AVDA>.

[aerorahul]

@climbfuji
All the nceplibs-xyz and EMC_post library built with this branch.
I will try ufs_utils next.

[climbfuji]

@climbfuji
All the nceplibs-xyz and EMC_post library built with this branch.
I will try ufs_utils next.

Thanks, @aerorahul. Once we know that ufs_utils works as well, we can merge this PR. Are you going to update the submodule pointers in those repositories you tested?

[aerorahul]

@climbfuji
All the nceplibs-xyz and EMC_post library built with this branch.
I will try ufs_utils next.

Thanks, @aerorahul. Once we know that ufs_utils works as well, we can merge this PR. Are you going to update the submodule pointers in those repositories you tested?

Sure @climbfuji. I can update the submodule pointers in those repos. I want to make sure everything works before I issue PR's. Would that be OK?

[climbfuji]

@climbfuji
All the nceplibs-xyz and EMC_post library built with this branch.
I will try ufs_utils next.

Thanks, @aerorahul. Once we know that ufs_utils works as well, we can merge this PR. Are you going to update the submodule pointers in those repositories you tested?

Sure @climbfuji. I can update the submodule pointers in those repos. I want to make sure everything works before I issue PR's. Would that be OK?

Absolutely, this can wait. Thanks for testing all the codes.

[aerorahul]

@climbfuji
I tested this branch of CMakeModules with UFS_UTILS branch feature/cmakepkgs and it worked.

[aerorahul]

works with nceplibs-xyz and ufs_utils.

[climbfuji]

works with nceplibs-xyz and ufs_utils.

Great, thanks. So, can we merge?

[aerorahul]

works with nceplibs-xyz and ufs_utils.

Great, thanks. So, can we merge?

I think so.