Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Cleanup, updates and bug fixes following the wgrib2 update#57

Merged
climbfuji merged 4 commits into
NOAA-EMC:developfrom
climbfuji:updates_and_bugfixes_post_wgrib2
Jul 31, 2020
Merged

Cleanup, updates and bug fixes following the wgrib2 update#57
climbfuji merged 4 commits into
NOAA-EMC:developfrom
climbfuji:updates_and_bugfixes_post_wgrib2

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jul 29, 2020 •
edited
Loading

  • fix a few bugs for building wgrib2 if netCDF et al. are not built by NCEPLIBS-external
  • clean up the top-level CMakeLists.txt and point to a cleaned up version of CMakeModules
  • works on macosx.gnu, cheyenne.intel, cheyenne.gnu, gaea.intel, jet.intel, and passes the CI tests.
  • waiting for Remove unused cmake macros CMakeModules#40

@climbfuji climbfuji marked this pull request as ready for review July 29, 2020 19:40
@climbfuji climbfuji mentioned this pull request Jul 29, 2020
Merged
kgerheiser
kgerheiser approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kgerheiser kgerheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@climbfuji climbfuji merged commit f3bf946 into NOAA-EMC:develop Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts

1 more reviewer

@kgerheiser kgerheiser kgerheiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@climbfuji @kgerheiser