Skip to content

update pointer to CMakeModules#156

Merged
WenMeng-NOAA merged 1 commit into
developfrom
feature/update-CMakeModules
Aug 4, 2020
Merged

update pointer to CMakeModules#156
WenMeng-NOAA merged 1 commit into
developfrom
feature/update-CMakeModules

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

update pointer to CMakeModules following CMakeModules PR 40

@aerorahul aerorahul requested review from climbfuji and fossell July 31, 2020 02:02
@fossell
Copy link
Copy Markdown
Contributor

fossell commented Jul 31, 2020

Is this change also need for SRW app v1.0 (release/public-v2 branch)? Or is this purely development?

@climbfuji
Copy link
Copy Markdown
Contributor

Is this change also need for SRW app v1.0 (release/public-v2 branch)? Or is this purely development?

I can tell you that it is not needed for MRW app v1.1 (release/public-v1) - I can't tell you right away if it should go into release/public-v2. I hope it will, though.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@fossell and @aerorahul I might think this #PR is an update of CAMKE build capacity, will have no impact on GNC build and change the UPP regression tests, right?

@aerorahul
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA
This PR does not impact GNU builds.
This PR is an update to the cleanup from @climbfuji

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@aerorahul Thanks for clarifying. I might wait for @fossell's reviewing.

@fossell
Copy link
Copy Markdown
Contributor

fossell commented Aug 4, 2020

All - apologies for delayed response, had other project priorities to address. This is ok with me, I'll work with SRW team as needed to see if they will need this for their build.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@fossell Thanks for confirming. I will proceed merging in branch develop.

@WenMeng-NOAA WenMeng-NOAA merged commit 688c425 into develop Aug 4, 2020
@aerorahul aerorahul deleted the feature/update-CMakeModules branch June 27, 2022 20:09
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
This PR removes dependency information from the CCPP prebuild config. See NCAR/ccpp-framework#308 and NCAR/ccpp-framework#317 for details on the motivation for this change and the actual implementation. It also removes some legacy code used by the dynamic CCPP build in the past.

This PR also contains the changes in NOAA-EMC#156, i.e. the completion of adding the active attribute to GFS_typedefs.F90. On top of this PR, the missing active attribute for phy_fctd is added.

Additionally, gfortran-10 compiler flags are added to CCPP's CMakeLists.txt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants