Skip to content

UFS-dev PR#305#1168

Merged
grantfirl merged 24 commits into
NCAR:mainfrom
grantfirl:ufs-dev-PR305
Nov 6, 2025
Merged

UFS-dev PR#305#1168
grantfirl merged 24 commits into
NCAR:mainfrom
grantfirl:ufs-dev-PR305

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Oct 20, 2025

Description of Changes:

Identical to ufs-community#305; updates RRTMGP to v1.8

Tests Conducted:

SCM RTs

Dependencies:

None

Documentation:

N/A

Issue (optional):

N/A

Contributors (optional):

@dustinswales

Qingfu-Liu and others added 22 commits March 20, 2025 09:31
@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 20, 2025

Note: I'm getting the following runtime error on my Mac when trying to run any suite with RRTMGP:

In file ccpp/physics/physics/Radiation/RRTMGP/rrtmgp_sw_gas_optics.F90, around line 215: Error allocating 10679244865963377664 bytes: Cannot allocate memory

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 20, 2025

@scrasmussen @hertneky @climbfuji

It looks like the issue above is that data that RRTMGP needs is no longer found in the repo that is cloned for rte-rrtmgp. It is now in https://github.com/earth-system-radiation/rrtmgp-data. If I manually download the data as follows:

and put these files in locations spelled out in the physics namelists, the code runs.

I think that we need to talk to @dustinswales to understand what to do with this data. I honestly don't know how ufs-community/ufs-weather-model#2823 passed RTs since the SCM exits with the runtime error above without these files.

We could set up a script like for the Thompson data to grab the RRTMGP data files and stage them somewhere in the ccpp-scm directory, but I'll let him chime in first after the shutdown ends.

@grantfirl grantfirl marked this pull request as ready for review October 20, 2025 20:48
Comment thread physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90 Outdated
Comment thread physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90 Outdated
Comment thread physics/Radiation/RRTMGP/rrtmgp_lw_cloud_optics.F90
call mpi_bcast(radliq_facLW, 1, MPI_DOUBLE_PRECISION, mpiroot, mpicomm, mpierr)
call mpi_bcast(radice_facLW, 1, MPI_DOUBLE_PRECISION, mpiroot, mpicomm, mpierr)
#ifdef RTE_USE_SP
call mpi_bcast(radliq_lwrLW, 1, MPI_REAL, mpiroot, mpicomm, mpierr)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using the ccpp mpi utilities for this imo ...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not within the scope of this PR

@grantfirl grantfirl mentioned this pull request Oct 21, 2025
Comment thread CMakeLists.txt Outdated
Comment thread physics/Radiation/RRTMGP/rrtmgp_lw_cloud_optics.F90
@grantfirl grantfirl merged commit c2abda0 into NCAR:main Nov 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants