Skip to content

Combination of NRL PRs and UFS/dev #304#596

Merged
grantfirl merged 5 commits into
NCAR:mainfrom
grantfirl:return-on-error
Sep 3, 2025
Merged

Combination of NRL PRs and UFS/dev #304#596
grantfirl merged 5 commits into
NCAR:mainfrom
grantfirl:return-on-error

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Jun 23, 2025

SOURCE: @grantfirl

DESCRIPTION OF CHANGES:

  • Point to combination ccpp-physics branch

ISSUE: None

ASSOCIATED PRs:
NCAR/ccpp-physics#1159

TESTS CONDUCTED: SCM RTs and UFS RTs

REGRESSION TEST CHANGES: None expected.

@grantfirl grantfirl marked this pull request as ready for review September 2, 2025 21:20
@grantfirl grantfirl changed the title Return-on-error changes from NRL Combination of NRL PRs and UFS/dev #304 Sep 2, 2025
@grantfirl
Copy link
Copy Markdown
Collaborator Author

@hertneky @scrasmussen This is good to go once approved. The RT results showed that the same tests differed as with #614 , which is expected because the baselines haven't been updated yet.

@grantfirl grantfirl merged commit 7584297 into NCAR:main Sep 3, 2025
13 checks passed
@grantfirl
Copy link
Copy Markdown
Collaborator Author

@hertneky @scrasmussen I merged this because it was only updating the ccpp/physics submodule (and that PR was needed by NRL) and the RTs were identical to the previous PR. We still need to update baselines (either from this PR or from the previous one -- they should be identical).

@hertneky
Copy link
Copy Markdown
Collaborator

hertneky commented Sep 4, 2025

@hertneky @scrasmussen I merged this because it was only updating the ccpp/physics submodule (and that PR was needed by NRL) and the RTs were identical to the previous PR. We still need to update baselines (either from this PR or from the previous one -- they should be identical).

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants