Update surface net heat fluxes for AQM coupling#953
Closed
rmontuoro wants to merge 1 commit into
Closed
Conversation
rmontuoro
requested review from
ChunxiZhang-NOAA,
SamuelTrahanNOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
This was referenced Aug 23, 2022
| dtsfci_cpl(i) = cp * rho * hflx_wat(i) ! sensible heat flux over open ocean | ||
| dqsfci_cpl(i) = hvap * rho * evap_wat(i) ! latent heat flux over open ocean | ||
| else ! use results from PBL scheme for 100% open ocean | ||
| if (cplaqm) then |
Contributor
There was a problem hiding this comment.
When running AQM, it only couples to ATM and ATM doesn't couple to Ocean or Ice model. I would suggest to make it simple by changing the code to:
if (cplaqm .and. .not. cplflx) then
do i = 1, im
dtsfci_cpl(i) = dtsfc1(i)*hffac(i)
dqsfci_cpl(i) = dqsfc1(i)
end do
end if
Contributor
Author
There was a problem hiding this comment.
I would prefer to leave in place the ability to use AQM in fully coupled mode for future applications.
grantfirl
approved these changes
Aug 26, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
This looks OK to me if @ChunxiZhang-NOAA is happy with this.
Contributor
|
@grantfirl I am ok with it. |
Collaborator
|
Closed in favor of #962 |
grantfirl
added a commit
that referenced
this pull request
Sep 9, 2022
Update surface net heat fluxes for AQM coupling (Was #953)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements proper computation of surface net heat fluxes provided to the coupled NOAA Air Quality Model (AQM).
The update uses PBL-computed fluxes both for fractional and non-fractional grids unless
cplflxis set to.true..Fixes #945.